-
Notifications
You must be signed in to change notification settings - Fork 265
Examples: Turn cuda_bindings examples into proper examples #1838
Copy link
Copy link
Open
Labels
cuda.bindingsEverything related to the cuda.bindings moduleEverything related to the cuda.bindings moduledocumentationImprovements or additions to documentationImprovements or additions to documentationtriageNeeds the team's attentionNeeds the team's attention
Milestone
Description
Is this a duplicate?
- I confirmed there appear to be no duplicate issues for this request and that I agree to the Code of Conduct
Area
cuda.bindings
Is your feature request related to a problem? Please describe.
Many of the cuda-bindings examples are not proper examples, they are unit tests of unusual construction.
A good example should be able to be downloaded, and having installed all dependencies should run and do something interesting. Many of the cuda-bindings examples don't do that.
- They depend on pytest and do things like
pytest.skip. - They depend on a locally-installed helper library (
common). Ideally, these would be added tocuda-bindingsand installed as a submodule. Even barring that, at minimum, the examples should update their import path so these helpers are importable. As it stands now, the examples are dependent on thecwdwhen it is run.
Describe the solution you'd like
Examples shouldn't have any dependencies that aren't necessary to demonstrate their purpose (e.g. pytest).
Examples shouldn't require the cwd to be something specific.
The common library should either be moved to a submodule of cuda-bindings or the examples should add a relative path to sys.path so it is always importable.
Describe alternatives you've considered
No response
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
cuda.bindingsEverything related to the cuda.bindings moduleEverything related to the cuda.bindings moduledocumentationImprovements or additions to documentationImprovements or additions to documentationtriageNeeds the team's attentionNeeds the team's attention