Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shfl_scan 's shuffle_integral_image_test has some misleading code. #273

Open
zhou3968322 opened this issue Jun 7, 2024 · 0 comments
Open

Comments

@zhou3968322
Copy link

zhou3968322 commented Jun 7, 2024

checkCudaErrors(cudaMalloc(reinterpret_cast<void **>(&d_data), sz));
checkCudaErrors(cudaMalloc(reinterpret_cast<void **>(&d_integral_image),
n_elements * sizeof(int) * 4));
checkCudaErrors(cudaMemset(d_data, 1, sz));
checkCudaErrors(cudaMemset(d_integral_image, 0, sz));

The size of d_data and d_integral_image here can be misleading.

  int n_elements = w * h;
  int sz = sizeof(unsigned int) * n_elements;
  checkCudaErrors(cudaMallocHost(reinterpret_cast<void **>(&h_image), sz));
  
  
  checkCudaErrors(cudaMalloc(reinterpret_cast<void **>(&d_data), sz));
  checkCudaErrors(cudaMalloc(reinterpret_cast<void **>(&d_integral_image),
                             n_elements * sizeof(int) * 4));
  checkCudaErrors(cudaMemset(d_data, 1, sz));
  checkCudaErrors(cudaMemset(d_integral_image, 0, sz));

d_data 's size is (w * h) *sizeof(char) in this ap, while malloc it with w * h *sizeof(unsigned int).
d_integral_image's size is n_elements * sizeof(int) in this ap.
Current version has a puzzling size.

change it to:

  int n_elements = w * h;
  int sz = sizeof(unsigned int) * n_elements;
  checkCudaErrors(cudaMallocHost(reinterpret_cast<void **>(&h_image), sz));
  
  
  checkCudaErrors(cudaMalloc(reinterpret_cast<void **>(&d_data), sz / 4));
  checkCudaErrors(cudaMalloc(reinterpret_cast<void **>(&d_integral_image),
                             n_elements * sizeof(int)));
  checkCudaErrors(cudaMemset(d_data, 1, sz / 4));
  checkCudaErrors(cudaMemset(d_integral_image, 0, sz));

may be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant