Skip to content

TEST: Remove passing pandas expected failure - #24022

Closed
vyasr wants to merge 2 commits into
NVIDIA:mainfrom
vyasr:codex/remove-passing-pandas-xfail
Closed

TEST: Remove passing pandas expected failure#24022
vyasr wants to merge 2 commits into
NVIDIA:mainfrom
vyasr:codex/remove-passing-pandas-xfail

Conversation

@vyasr

@vyasr vyasr commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Description

Remove the stale strict expected-failure marker for test_constructor_dict. The test now passes in the cudf.pandas CI suite; retaining the marker turns that result into an XPASS failure.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr
vyasr requested a review from a team as a code owner September 7, 2026 05:36
@vyasr
vyasr requested a review from rjzamora September 7, 2026 05:36
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas labels Sep 7, 2026
@vyasr vyasr added tests Unit testing for project non-breaking Non-breaking change labels Sep 7, 2026
@vyasr

vyasr commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@vyasr vyasr added the bug Something isn't working label Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: de3568a7-2455-465f-a49d-f26fad0736bb

📥 Commits

Reviewing files that changed from the base of the PR and between a8ad204 and 2708877.

📒 Files selected for processing (1)
  • python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py
💤 Files with no reviewable changes (1)
  • python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Removed the expected-failure designation for the dictionary constructor test.

Walkthrough

The pandas testing plugin no longer marks test_constructor_dict as an expected failure.

Changes

Pandas testing configuration

Layer / File(s) Summary
Remove constructor expected failure
python/cudf/cudf/pandas/scripts/pandas-testing-plugin.py
Removed the expected-failure configuration for test_constructor_dict.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 27088

The change removes an obsolete expected-failure marker so the passing constructor test no longer produces an XPASS failure. No current merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: removing a passing pandas expected-failure marker.
Description check ✅ Passed The description directly explains why the stale strict expected-failure marker for test_constructor_dict must be removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr

vyasr commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Closing: current upstream/main still has a real cudf.pandas mismatch in this test (30 != 25), so the expected-failure entry is valid. The XPASS on #24015 and #24016 is caused by their stale bases; those branches will be rebased instead.

@vyasr vyasr closed this Sep 7, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant