Skip to content

Commit 506098f

Browse files
committed
[no-relnote] Update for modified nvcdi GetSpecs API
Signed-off-by: Evan Lezar <[email protected]>
1 parent 1a192f5 commit 506098f

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

internal/cdi/api.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,10 @@
1616

1717
package cdi
1818

19-
import "github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/spec"
20-
2119
// Interface provides the API to the 'cdi' package
2220
//
2321
//go:generate moq -stub -out api_mock.go . Interface
2422
type Interface interface {
2523
CreateSpecFile() error
2624
QualifiedName(string, string) string
2725
}
28-
29-
type cdiSpecGenerator interface {
30-
GetSpec() (spec.Interface, error)
31-
}

internal/cdi/cdi.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ type cdiHandler struct {
6262

6363
imexChannels imex.Channels
6464

65-
cdilibs map[string]cdiSpecGenerator
65+
cdilibs map[string]nvcdi.SpecGenerator
6666
}
6767

6868
var _ Interface = &cdiHandler{}
@@ -111,7 +111,7 @@ func New(infolib info.Interface, nvmllib nvml.Interface, devicelib device.Interf
111111
return nil, err
112112
}
113113

114-
c.cdilibs = make(map[string]cdiSpecGenerator)
114+
c.cdilibs = make(map[string]nvcdi.SpecGenerator)
115115

116116
c.cdilibs["gpu"], err = nvcdi.New(
117117
nvcdi.WithInfoLib(c.infolib),

internal/cdi/imex.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package cdi
1919
import (
2020
"tags.cncf.io/container-device-interface/specs-go"
2121

22+
"github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi"
2223
"github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/spec"
2324

2425
"github.com/NVIDIA/k8s-device-plugin/internal/imex"
@@ -29,7 +30,7 @@ type imexChannelCDILib struct {
2930
imexChannels imex.Channels
3031
}
3132

32-
func (cdi *cdiHandler) newImexChannelSpecGenerator() cdiSpecGenerator {
33+
func (cdi *cdiHandler) newImexChannelSpecGenerator() nvcdi.SpecGenerator {
3334
lib := &imexChannelCDILib{
3435
vendor: cdi.vendor,
3536
imexChannels: cdi.imexChannels,
@@ -39,7 +40,7 @@ func (cdi *cdiHandler) newImexChannelSpecGenerator() cdiSpecGenerator {
3940
}
4041

4142
// GetSpec returns the CDI specs for IMEX channels.
42-
func (l *imexChannelCDILib) GetSpec() (spec.Interface, error) {
43+
func (l *imexChannelCDILib) GetSpec(...string) (spec.Interface, error) {
4344
var deviceSpecs []specs.Device
4445
for _, channel := range l.imexChannels {
4546
deviceSpec := specs.Device{

0 commit comments

Comments
 (0)