-
Notifications
You must be signed in to change notification settings - Fork 9
[BUG]: Makefile merge-coverage target hardcodes project name, breaks ci #190
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Problem
The merge-coverage target in operator/Makefile still references the old skyhook project name in the sed command that rewrites coverage profile paths:
$(sedrp) 's|^/.*skyhook/operator/(.*)$$|github\.com/NVIDIA/skyhook/operator/\1|g' $(REPORTING)/cover.out;Since the project was renamed to nodewright, the filesystem paths during CI contain nodewright/operator/ instead of skyhook/operator/. The sed regex never matches, leaving raw absolute paths in the coverage file, which Coveralls can't parse:
⚠️ Coverage reporter does not yet know how to process this file: operator/reporting/cover.out
🚨 Nothing to report
Error: Process completed with exit code 1.
Expected Behavior
The coverage path rewriting should use the current project name (nodewright).
Suggested Fix
Update the Go module name and the sed regex to reflect the rename:
$(sedrp) 's|^/.*nodewright/operator/(.*)$$|github\.com/NVIDIA/nodewright/operator/\1|g' $(REPORTING)/cover.out;The go.mod module path should also be updated from github.com/NVIDIA/skyhook/operator to github.com/NVIDIA/nodewright/operator if it hasn't been already.
References
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working