fix: improve reThrowToJava exception handling and runtime retrieval logic

Author: edusperoni

test-app/runtime/src/main/cpp/NativeScriptException.cpp

@@ -75,8 +75,7 @@ void NativeScriptException::ReThrowToJava() {
 
 
     if (!m_javaException.IsNull()) {
-        auto objectManager = Runtime::GetObjectManager(isolate);
-        auto excClassName = objectManager->GetClassName((jobject) m_javaException);
+        auto excClassName = ObjectManager::GetClassName((jobject) m_javaException);
         if (excClassName == "com/tns/NativeScriptException") {
             ex = m_javaException;
         } else {
@@ -103,8 +102,7 @@ void NativeScriptException::ReThrowToJava() {
         if (ex == nullptr) {
             ex = static_cast<jthrowable>(env.NewObject(NATIVESCRIPTEXCEPTION_CLASS, NATIVESCRIPTEXCEPTION_JSVALUE_CTOR_ID, (jstring) msg, (jstring)stackTrace, reinterpret_cast<jlong>(m_javascriptException)));
         } else {
-            auto objectManager = Runtime::GetObjectManager(isolate);
-            auto excClassName = objectManager->GetClassName(ex);
+            auto excClassName = ObjectManager::GetClassName(ex);
             if (excClassName != "com/tns/NativeScriptException") {
                 ex = static_cast<jthrowable>(env.NewObject(NATIVESCRIPTEXCEPTION_CLASS, NATIVESCRIPTEXCEPTION_THROWABLE_CTOR_ID, (jstring) msg, (jstring)stackTrace, ex));
             }
@@ -184,9 +182,8 @@ Local<Value> NativeScriptException::WrapJavaToJsException() {
     JEnv env;
 
     auto isolate = Isolate::GetCurrent();
-    auto objectManager = Runtime::GetObjectManager(isolate);
 
-    string excClassName = objectManager->GetClassName((jobject) m_javaException);
+    string excClassName = ObjectManager::GetClassName((jobject) m_javaException);
     if (excClassName == "com/tns/NativeScriptException") {
         jfieldID fieldID = env.GetFieldID(env.GetObjectClass(m_javaException), "jsValueAddress", "J");
         jlong addr = env.GetLongField(m_javaException, fieldID);

test-app/runtime/src/main/cpp/Runtime.cpp

@@ -132,15 +132,15 @@ Runtime* Runtime::GetRuntime(int runtimeId) {
 }
 
 Runtime* Runtime::GetRuntime(v8::Isolate* isolate) {
-    auto runtime = s_isolate2RuntimesCache.at(isolate);
+    auto it = s_isolate2RuntimesCache.find(isolate);
 
-    if (runtime == nullptr) {
+    if (it == s_isolate2RuntimesCache.end()) {
         stringstream ss;
         ss << "Cannot find runtime for isolate: " << isolate;
         throw NativeScriptException(ss.str());
     }
 
-    return runtime;
+    return it->second;
 }
 
 Runtime* Runtime::GetRuntimeFromIsolateData(v8::Isolate* isolate) {