Skip to content

Commit 86359fa

Browse files
committed
v8: fix v8 build failing due to incorrect args
1 parent 464a8a4 commit 86359fa

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

test-app/runtime/CMakeLists.txt

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,17 @@ if (CCACHE_FOUND AND (USE_CCACHE))
1616
MESSAGE(STATUS "## Using CCache when building!")
1717
set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)
1818
set_property(GLOBAL PROPERTY RULE_LAUNCH_LINK ccache)
19-
endif (CCACHE_FOUND AND (USE_CCACHE))
19+
endif ()
2020

21-
set(COMMON_CMAKE_ARGUMENTS "-std=c++17 -Wno-error -Wno-deprecated-declarations -Wno-unused-result -mstackrealign -fexceptions -fno-builtin-stpcpy -frtti")
21+
set(COMMON_CMAKE_ARGUMENTS "-std=c++17 -Wno-error -Wno-deprecated-declarations -Wno-unused-result -mstackrealign -fexceptions -fno-builtin-stpcpy")
2222
set(MI_OVERRIDE OFF)
23+
24+
if (SHERMES)
25+
set(COMMON_CMAKE_ARGUMENTS "${COMMON_CMAKE_ARGUMENTS} -frtti")
26+
else()
27+
set(COMMON_CMAKE_ARGUMENTS "${COMMON_CMAKE_ARGUMENTS} -fno-rtti")
28+
endif()
29+
2330
# AOSP has switched to using LLD by default and the NDK will use it by default in the next release.
2431
# BFD and Gold will be removed once LLD has been through a release cycle with no major unresolved issues (estimated r21)
2532
# Note: lld does not currently work on Windows: https://github.com/android-ndk/ndk/issues/888

0 commit comments

Comments
 (0)