cleared status resets on re-import

[Yumekui]

Issue:
When importing transactions a second time, their cleared status is reset to false. I have the setting import.synchronizeClearedStatus set to false.

Expected Behavior:
The cleared status should not be reset when re-importing transactions, as per my current configuration.

Reference:
According to the Actual Budget API documentation, setting the cleared status is not required. However, convertToActualTransaction sets cleared to false when the import.synchronizeClearedStatus setting is false:

actual-moneymoney/src/utils/Importer.ts

Lines 373 to 387 in 107a8a0

	private async convertToActualTransaction(
	transaction: MonMonTransaction
	): Promise<CreateTransaction> {
	return {
	date: format(transaction.valueDate, 'yyyy-MM-dd'),
	amount: Math.round(transaction.amount * 100),
	imported_id: this.getIdForMoneyMoneyTransaction(transaction),
	imported_payee: transaction.name,
	cleared: this.config.import.synchronizeClearedStatus
	? transaction.booked
	: false,
	notes: transaction.purpose,
	// payee_name: transaction.name,
	};
	}

Additional Information:
I'm not proficient in JavaScript but can test this behavior further once I have set up a suitable environment, which may take some time.

Please let me know if additional details are required. Thank you!

[NikxDa]

Hi @Yumekui,

thanks for reporting this. I will have to check whether Actual skips updating the cleared flag if I pass undefined instead of false, which I would assume it should do. If it does, I will release a bugfix release that solves this shortly.

[NikxDa]

I've had a look at this tonight and it turns out that Actual defaults the cleared flag to true (see here), which means that if I do not provide it as false, it will be reset to true instead. This is of course similarly useless behavior.

My opinion is that the defaults should only apply when creating transactions in Actual, not when updating. I will raise this with the Actual team and put this ticket on hold until then.

[Yumekui]

Thanks for looking into this! I agree with you - defaulting the cleared flag to true when updating doesn’t seem right. Makes sense to check with the Actual team. Appreciate your help!

[NikxDa]

@Yumekui Good news! My proposed changes to the API implementation were merged earlier today, so on the next API release in February, I'll be able to hook this up on the importer side as well. Stay tuned :)

[Yumekui]

Oh wow. That's really great news! Thank you very much for your fast response and all the work you put into this. This will make managing my finances much easier. Keep up the great work!