fix: remove unsafe casting with ensureError

Author: schaable

v-next/hardhat-utils/src/errors/request.ts

@@ -2,6 +2,7 @@ import type UndiciT from "undici";
 
 import { CustomError } from "../error.js";
 import { sanitizeUrl } from "../internal/request.js";
+import { isObject } from "../lang.js";
 
 export class RequestError extends CustomError {
   constructor(url: string, type: UndiciT.Dispatcher.HttpMethod, cause?: Error) {
@@ -41,10 +42,43 @@ export class ResponseStatusCodeError extends CustomError {
     | null;
   public readonly body: null | Record<string, any> | string;
 
-  constructor(url: string, cause: UndiciT.errors.ResponseStatusCodeError) {
+  constructor(url: string, cause: Error) {
     super(`Received an unexpected status code from ${sanitizeUrl(url)}`, cause);
-    this.statusCode = cause.statusCode;
-    this.headers = cause.headers;
-    this.body = cause.body;
+    this.statusCode =
+      "statusCode" in cause && typeof cause.statusCode === "number"
+        ? cause.statusCode
+        : -1;
+    this.headers = this.#extractHeaders(cause);
+    this.body = "body" in cause && isObject(cause.body) ? cause.body : null;
+  }
+
+  #extractHeaders(
+    cause: Error,
+  ): string[] | Record<string, string | string[] | undefined> | null {
+    if ("headers" in cause) {
+      const headers = cause.headers;
+      if (Array.isArray(headers)) {
+        return headers;
+      } else if (this.#isValidHeaders(headers)) {
+        return headers;
+      }
+    }
+    return null;
+  }
+
+  #isValidHeaders(
+    headers: unknown,
+  ): headers is Record<string, string | string[] | undefined> {
+    if (!isObject(headers)) {
+      return false;
+    }
+
+    return Object.values(headers).every(
+      (header) =>
+        typeof header === "string" ||
+        (Array.isArray(header) &&
+          header.every((item: unknown) => typeof item === "string")) ||
+        header === undefined,
+    );
   }
 }

v-next/hardhat-utils/src/internal/request.ts

@@ -5,8 +5,8 @@ import type UndiciT from "undici";
 import path from "node:path";
 import url from "node:url";
 
-import { ensureError } from "../error.js";
 import { mkdir } from "../fs.js";
+import { isObject } from "../lang.js";
 import {
   ConnectionRefusedError,
   DEFAULT_MAX_REDIRECTS,
@@ -140,16 +140,12 @@ export function sanitizeUrl(requestUrl: string): string {
   return url.format(parsedUrl, { auth: false, search: false, fragment: false });
 }
 
-export function handleError(
-  e: NodeJS.ErrnoException,
-  requestUrl: string,
-): void {
-  let causeCode;
-  if (e.cause !== undefined) {
-    ensureError<NodeJS.ErrnoException>(e.cause);
+export function handleError(e: Error, requestUrl: string): void {
+  let causeCode: unknown;
+  if (isObject(e.cause)) {
     causeCode = e.cause.code;
   }
-  const errorCode = e.code ?? causeCode;
+  const errorCode = "code" in e ? e.code : causeCode;
 
   if (errorCode === "ECONNREFUSED") {
     throw new ConnectionRefusedError(requestUrl, e);
@@ -164,7 +160,6 @@ export function handleError(
   }
 
   if (errorCode === "UND_ERR_RESPONSE_STATUS_CODE") {
-    ensureError<UndiciT.errors.ResponseStatusCodeError>(e);
     throw new ResponseStatusCodeError(requestUrl, e);
   }
 }

v-next/hardhat-utils/src/request.ts

@@ -91,7 +91,7 @@ export async function getRequest(
       ...baseRequestOptions,
     });
   } catch (e) {
-    ensureError<NodeJS.ErrnoException>(e);
+    ensureError(e);
 
     handleError(e, url);
 
@@ -135,7 +135,7 @@ export async function postJsonRequest(
       body: JSON.stringify(body),
     });
   } catch (e) {
-    ensureError<NodeJS.ErrnoException>(e);
+    ensureError(e);
 
     handleError(e, url);
 
@@ -180,7 +180,7 @@ export async function postFormRequest(
       body: querystring.stringify(body as ParsedUrlQueryInput),
     });
   } catch (e) {
-    ensureError<NodeJS.ErrnoException>(e);
+    ensureError(e);
 
     handleError(e, url);
 
@@ -225,7 +225,7 @@ export async function download(
     await stream.pipeline(body, fileStream);
     await move(tempFilePath, destination);
   } catch (e) {
-    ensureError<NodeJS.ErrnoException>(e);
+    ensureError(e);
 
     handleError(e, url);
 

v-next/hardhat-utils/test/lang.ts

@@ -359,6 +359,10 @@ describe("lang", () => {
         isObject(new Set()),
         "new Set() is an object, but isObject returned false",
       );
+      assert.ok(
+        isObject(new Error()),
+        "new Error() is an object, but isObject returned false",
+      );
     });
 
     it("Should return false for non-objects", () => {

v-next/hardhat/src/internal/network/http-provider.ts

@@ -153,9 +153,9 @@ export class HttpProvider extends EventEmitter implements EthereumProvider {
           result,
         };
       } catch (error) {
-        ensureError<Error & { code: unknown }>(error);
+        ensureError(error);
 
-        if (error.code === undefined) {
+        if (!("code" in error) || error.code === undefined) {
           throw error;
         }