Merge branch 'feature/add-logic-to-send-telemetry-data' of github.com:NomicFoundation/hardhat into features/port-sentry-to-V3

Author: ChristopherDedominici

v-next/hardhat/src/internal/cli/telemetry/telemetry-permissions.ts

@@ -47,15 +47,15 @@ export async function isTelemetryAllowed(): Promise<boolean> {
     return false;
   }
 
-  const consent = await getTelemetryConsent();
-
   // ATTENTION: only for testing
   if (process.env.HARDHAT_TEST_TELEMETRY_CONSENT_VALUE !== undefined) {
     return process.env.HARDHAT_TEST_TELEMETRY_CONSENT_VALUE === "true"
       ? true
       : false;
   }
 
+  const consent = await getTelemetryConsent();
+
   return consent !== undefined ? consent : false;
 }
 
@@ -72,7 +72,8 @@ export function isTelemetryAllowedInEnvironment(): boolean {
     (!isCi() &&
       process.stdout.isTTY === true &&
       process.env.HARDHAT_DISABLE_TELEMETRY_PROMPT !== "true") ||
-    process.env.HARDHAT_TEST_INTERACTIVE_ENV === "true" // Used in tests to force telemetry execution
+    // ATTENTION: used in tests to force telemetry execution
+    process.env.HARDHAT_TEST_INTERACTIVE_ENV === "true"
   );
 }
 

v-next/hardhat/test/internal/cli/telemetry/helpers.ts

@@ -1,6 +1,6 @@
 import path from "node:path";
 
-import { exists } from "@ignored/hardhat-vnext-utils/fs";
+import { exists, readUtf8File } from "@ignored/hardhat-vnext-utils/fs";
 
 export const ROOT_PATH_TO_FIXTURE: string = path.join(
   process.cwd(),
@@ -33,12 +33,15 @@ export async function checkIfSubprocessWasExecuted(
       counter++;
 
       if (await exists(resultFilePath)) {
-        clearInterval(intervalId);
-        resolve(true);
+        try {
+          await readUtf8File(resultFilePath); // Wait for the file to be readable
+          clearInterval(intervalId);
+          resolve(true);
+        } catch (_err) {}
       } else if (counter > MAX_COUNTER) {
         clearInterval(intervalId);
         reject("Subprocess was not executed in the expected time");
       }
-    }, 100);
+    }, 50);
   });
 }