Merge pull request #6143 from NomicFoundation/test-solidity-no-compile

galargh · web-flow · commit 1e591a661d71 · 2025-01-16T21:51:28.000Z
chore: check test task options before passing on noCompile flag
diff --git a/v-next/hardhat/src/internal/builtin-plugins/test/task-action.ts b/v-next/hardhat/src/internal/builtin-plugins/test/task-action.ts
@@ -16,7 +16,11 @@ const runAllTests: NewTaskActionFunction<TestActionArguments> = async (
   }
 
   for (const subtask of thisTask.subtasks.values()) {
-    await subtask.run({ noCompile: true });
+    if (subtask.options.has("noCompile")) {
+      await subtask.run({ noCompile: true });
+    } else {
+      await subtask.run({});
+    }
   }
 
   if (process.exitCode !== undefined && process.exitCode !== 0) {

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,11 @@ const runAllTests: NewTaskActionFunction<TestActionArguments> = async (`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`for (const subtask of thisTask.subtasks.values()) {`
`19`		`- await subtask.run({ noCompile: true });`
	`19`	`+ if (subtask.options.has("noCompile")) {`
	`20`	`+ await subtask.run({ noCompile: true });`
	`21`	`+ } else {`
	`22`	`+ await subtask.run({});`
	`23`	`+ }`
`20`	`24`	`}`
`21`	`25`
`22`	`26`	`if (process.exitCode !== undefined && process.exitCode !== 0) {`