PR fixes

Author: schaable

v-next/core/src/internal/tasks/builders.ts

@@ -19,7 +19,7 @@ import {
   isValidParamNameCasing,
 } from "../parameters.js";
 
-import { formatTaskId, formatValue, isValidActionUrl } from "./utils.js";
+import { formatTaskId, isValidActionUrl } from "./utils.js";
 
 export class NewTaskDefinitionBuilderImplementation
   implements NewTaskDefinitionBuilder
@@ -97,17 +97,13 @@ export class NewTaskDefinitionBuilderImplementation
       throw new HardhatError(
         HardhatError.ERRORS.ARGUMENTS.INVALID_VALUE_FOR_TYPE,
         {
-          value: formatValue(defaultValue),
+          value: defaultValue,
           name: "defaultValue",
           type: parameterType,
         },
       );
     }
 
-    if (type === ParameterType.BOOLEAN && defaultValue === undefined) {
-      defaultValue = false as ParameterTypeToValueType<T>;
-    }
-
     this.#usedNames.add(name);
 
     this.#namedParams[name] = {
@@ -235,7 +231,7 @@ export class NewTaskDefinitionBuilderImplementation
         throw new HardhatError(
           HardhatError.ERRORS.ARGUMENTS.INVALID_VALUE_FOR_TYPE,
           {
-            value: formatValue(defaultValue),
+            value: defaultValue,
             name: "defaultValue",
             type: parameterType,
           },
@@ -353,17 +349,13 @@ export class TaskOverrideDefinitionBuilderImplementation
       throw new HardhatError(
         HardhatError.ERRORS.ARGUMENTS.INVALID_VALUE_FOR_TYPE,
         {
-          value: formatValue(defaultValue),
+          value: defaultValue,
           name: "defaultValue",
           type: parameterType,
         },
       );
     }
 
-    if (type === ParameterType.BOOLEAN && defaultValue === undefined) {
-      defaultValue = false as ParameterTypeToValueType<T>;
-    }
-
     this.#namedParams[name] = {
       name,
       description,

v-next/core/src/internal/tasks/utils.ts

@@ -1,8 +1,3 @@
-import type {
-  ParameterType,
-  ParameterTypeToValueType,
-} from "../../types/common.js";
-
 export function formatTaskId(taskId: string | string[]): string {
   if (typeof taskId === "string") {
     return taskId;
@@ -16,13 +11,3 @@ const FILE_PROTOCOL_PATTERN = /^file:\/\/.+/;
 export function isValidActionUrl(action: string): boolean {
   return FILE_PROTOCOL_PATTERN.test(action);
 }
-
-export function formatValue<T extends ParameterType>(
-  value: ParameterTypeToValueType<T> | Array<ParameterTypeToValueType<T>>,
-): string {
-  if (typeof value === "bigint") {
-    return `${value}n`;
-  }
-
-  return JSON.stringify(value);
-}

v-next/core/src/types/common.ts

@@ -10,7 +10,10 @@ export enum ParameterType {
   FILE = "FILE",
 }
 
-interface ParameterToValueTypeMap {
+/**
+ * Maps all the `ParameterType` values to their corresponding value types.
+ */
+export interface ParameterToValueTypeMap {
   [ParameterType.STRING]: string;
   [ParameterType.BOOLEAN]: boolean;
   [ParameterType.INT]: number;
@@ -25,8 +28,13 @@ interface ParameterToValueTypeMap {
  * This type takes a `ParameterType` as a type parameter and returns the type
  * of the value that should be used for parameters of that type.
  *
- * For example, `ParameterTypeToValueType<ParameterType.STRING>` would be
- * `string`, and `ParameterTypeToValueType<ParameterType.INT>` would be `number`.
+ * @example
+ * ParameterTypeToValueType<ParameterType.STRING>
+ * // ^? "string"
+ *
+ * @example
+ * ParameterTypeToValueType<ParameterType.INT>
+ * // ^? "number"
  */
 export type ParameterTypeToValueType<T extends ParameterType> =
   ParameterToValueTypeMap[T];