Prefer non-strict methods when using node:assert/strict

Author: schaable

config-v-next/eslint.cjs

@@ -214,6 +214,12 @@ function createConfig(configFilePath, packageEntryPoints = []) {
           message:
             "Use ensureError() or HardhatError.isHardhatError instead of casting the error",
         },
+        {
+          selector:
+            "CallExpression[callee.object.name='assert'][callee.property.name=/strict/i]",
+          message:
+            "Use non-strict methods when importing from 'node:assert/strict'",
+        },
       ],
       "@typescript-eslint/restrict-plus-operands": "error",
       "@typescript-eslint/restrict-template-expressions": [

v-next/core/test/internal/plugins/resolve-plugin-list.ts

@@ -10,14 +10,11 @@ describe("Plugins - resolve plugin list", () => {
   );
 
   it("should return empty on an empty plugin list", async () => {
-    assert.deepStrictEqual(
-      await resolvePluginList([], installedPackageFixture),
-      [],
-    );
+    assert.deepEqual(await resolvePluginList([], installedPackageFixture), []);
   });
 
   it("should return empty on an undefined plugin list", async () => {
-    assert.deepStrictEqual(
+    assert.deepEqual(
       await resolvePluginList(undefined, installedPackageFixture),
       [],
     );
@@ -28,7 +25,7 @@ describe("Plugins - resolve plugin list", () => {
       id: "example-plugin",
     };
 
-    assert.deepStrictEqual(
+    assert.deepEqual(
       await resolvePluginList([plugin], installedPackageFixture),
       [plugin],
     );
@@ -40,9 +37,10 @@ describe("Plugins - resolve plugin list", () => {
     const b: HardhatPlugin = { id: "b", dependencies: [async () => c] };
     const a: HardhatPlugin = { id: "a", dependencies: [async () => b] };
 
-    assert.deepStrictEqual(
+    const expected = [c, b, a];
+    assert.deepEqual(
       await resolvePluginList([a], installedPackageFixture),
-      [c, b, a],
+      expected,
     );
   });
 
@@ -52,9 +50,10 @@ describe("Plugins - resolve plugin list", () => {
     const b: HardhatPlugin = { id: "b" };
     const a: HardhatPlugin = { id: "a" };
 
-    assert.deepStrictEqual(
+    const expected = [a, b, c];
+    assert.deepEqual(
       await resolvePluginList([a, b, c], installedPackageFixture),
-      [a, b, c],
+      expected,
     );
   });
 
@@ -69,9 +68,10 @@ describe("Plugins - resolve plugin list", () => {
       dependencies: [async () => b, async () => c],
     };
 
-    assert.deepStrictEqual(
+    const expected = [b, c, a];
+    assert.deepEqual(
       await resolvePluginList([a], installedPackageFixture),
-      [b, c, a],
+      expected,
     );
   });
 
@@ -83,9 +83,10 @@ describe("Plugins - resolve plugin list", () => {
     const b: HardhatPlugin = { id: "b", dependencies: [async () => c] };
     const a: HardhatPlugin = { id: "a", dependencies: [async () => c] };
 
-    assert.deepStrictEqual(
+    const expected = [c, a, b];
+    assert.deepEqual(
       await resolvePluginList([a, b], installedPackageFixture),
-      [c, a, b],
+      expected,
     );
   });
 
@@ -103,9 +104,10 @@ describe("Plugins - resolve plugin list", () => {
       dependencies: [async () => b, async () => c],
     };
 
-    assert.deepStrictEqual(
+    const expected = [d, b, c, a];
+    assert.deepEqual(
       await resolvePluginList([a], installedPackageFixture),
-      [d, b, c, a],
+      expected,
     );
   });
 
@@ -133,9 +135,10 @@ describe("Plugins - resolve plugin list", () => {
       dependencies: [async () => c, async () => d],
     };
 
-    assert.deepStrictEqual(
+    const expected = [i, g, c, d, a, h, e, f, b];
+    assert.deepEqual(
       await resolvePluginList([a, b], installedPackageFixture),
-      [i, g, c, d, a, h, e, f, b],
+      expected,
     );
   });
 

v-next/hardhat-utils/test/fs.ts

@@ -576,7 +576,7 @@ describe("File system utils", () => {
       const encoder = new TextEncoder();
       const binaryContent = encoder.encode(content);
 
-      assert.deepStrictEqual(await readBinaryFile(filePath), binaryContent);
+      assert.deepEqual(await readBinaryFile(filePath), binaryContent);
       expectTypeOf(await readBinaryFile(filePath)).toMatchTypeOf<Uint8Array>();
     });