Validate non-empty task id

Author: schaable

v-next/core/src/internal/tasks/builders.ts

@@ -35,6 +35,12 @@ export class NewTaskDefinitionBuilderImplementation
   #action?: NewTaskActionFunction | string;
 
   constructor(id: string | string[], description: string = "") {
+    if (id.length === 0) {
+      throw new HardhatError(
+        HardhatError.ERRORS.TASK_DEFINITIONS.EMPTY_TASK_ID,
+      );
+    }
+
     this.#id = Array.isArray(id) ? id : [id];
     this.#description = description;
   }
@@ -288,6 +294,12 @@ export class TaskOverrideDefinitionBuilderImplementation
   #action?: TaskOverrideActionFunction | string;
 
   constructor(id: string | string[]) {
+    if (id.length === 0) {
+      throw new HardhatError(
+        HardhatError.ERRORS.TASK_DEFINITIONS.EMPTY_TASK_ID,
+      );
+    }
+
     this.#id = Array.isArray(id) ? id : [id];
   }
 

v-next/core/test/internal/tasks/builders.ts

@@ -42,6 +42,26 @@ describe("Task builders", () => {
       });
     });
 
+    describe("Task id validation", () => {
+      it("should throw if the id is an empty string", () => {
+        assert.throws(() => new NewTaskDefinitionBuilderImplementation(""), {
+          name: "HardhatError",
+          message:
+            "HHE208: Task id cannot be an empty string or an empty array",
+        });
+      });
+
+      it("should throw if the array of ids is empty", () => {
+        const ids: string[] = [];
+
+        assert.throws(() => new NewTaskDefinitionBuilderImplementation(ids), {
+          name: "HardhatError",
+          message:
+            "HHE208: Task id cannot be an empty string or an empty array",
+        });
+      });
+    });
+
     describe("Adding an action", () => {
       it("should create a new task definition builder with an async function action", () => {
         const builder = new NewTaskDefinitionBuilderImplementation("task-id");
@@ -724,6 +744,32 @@ describe("Task builders", () => {
       });
     });
 
+    describe("Task id validation", () => {
+      it("should throw if the id is an empty string", () => {
+        assert.throws(
+          () => new TaskOverrideDefinitionBuilderImplementation(""),
+          {
+            name: "HardhatError",
+            message:
+              "HHE208: Task id cannot be an empty string or an empty array",
+          },
+        );
+      });
+
+      it("should throw if the array of ids is empty", () => {
+        const ids: string[] = [];
+
+        assert.throws(
+          () => new TaskOverrideDefinitionBuilderImplementation(ids),
+          {
+            name: "HardhatError",
+            message:
+              "HHE208: Task id cannot be an empty string or an empty array",
+          },
+        );
+      });
+    });
+
     describe("Adding an action", () => {
       it("should create a task override definition builder with an async function action", () => {
         const builder = new TaskOverrideDefinitionBuilderImplementation(