Skip to content

Commit 38a7f7d

Browse files
committed
all ignition packages linting and testing successfully
1 parent 051f1ec commit 38a7f7d

File tree

6 files changed

+11
-14
lines changed

6 files changed

+11
-14
lines changed

packages/hardhat-ignition-core/src/internal/journal/memory-journal.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,18 @@ import { emitExecutionEvent } from "./utils/emitExecutionEvent";
1010
* @beta
1111
*/
1212
export class MemoryJournal implements Journal {
13-
private messages: JournalMessage[] = [];
13+
private _messages: JournalMessage[] = [];
1414

1515
constructor(private _executionEventListener?: ExecutionEventListener) {}
1616

1717
public record(message: JournalMessage): void {
1818
this._log(message);
1919

20-
this.messages.push(message);
20+
this._messages.push(message);
2121
}
2222

2323
public async *read(): AsyncGenerator<JournalMessage> {
24-
for (const message of this.messages) {
24+
for (const message of this._messages) {
2525
yield message;
2626
}
2727
}

packages/hardhat-ignition-core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,15 @@ describe("JSON-RPC client", function () {
5353
return { artifact, address: receipt!.contractAddress! };
5454
}
5555

56-
describe("getChainId", async function () {
56+
describe("getChainId", function () {
5757
it("Should return the chainId as number", async function () {
5858
const chainId = await client.getChainId();
5959

6060
assert.equal(chainId, 31337);
6161
});
6262
});
6363

64-
describe("getLatestBlock", async function () {
64+
describe("getLatestBlock", function () {
6565
it("Should return the first block in the correct format", async function () {
6666
const block = await client.getLatestBlock();
6767

@@ -80,7 +80,7 @@ describe("JSON-RPC client", function () {
8080
});
8181
});
8282

83-
describe("getNetworkFees", async function () {
83+
describe("getNetworkFees", function () {
8484
describe("With an EIP-1559 network (i.e. Hardhat Network)", function () {
8585
it("Should return information about EIP-1559 fees", async function () {
8686
const fees = await client.getNetworkFees();

packages/hardhat-ignition-core/test/execution/abi.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ describe("abi", () => {
507507
});
508508
});
509509

510-
describe("When the function returns something and there's no clash", async () => {
510+
describe("When the function returns something and there's no clash", () => {
511511
it("should return RevertWithoutReason", async () => {
512512
const { decoded } = decode("C", "revertWithoutReasonWithoutClash");
513513
assert.deepEqual(decoded, {
@@ -631,7 +631,7 @@ describe("abi", () => {
631631
});
632632
});
633633

634-
describe("When the function returns something and there's no clash", async () => {
634+
describe("When the function returns something and there's no clash", () => {
635635
it("should return RevertWithoutReason", async () => {
636636
const { decoded } = decode("C", "invalidOpcode");
637637
assert.deepEqual(decoded, {

packages/hardhat-ignition-ethers/README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f)
2-
[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org)
1+
![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org)
32

43
---
54

packages/hardhat-ignition-viem/README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f)
2-
[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition-viem.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org)
1+
![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition-viem.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org)
32

43
---
54

packages/hardhat-ignition/README.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f)
2-
[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) [![Open in Dev Containers](https://img.shields.io/static/v1?label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/NomicFoundation/hardhat-ignition.git)
1+
![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) [![Open in Dev Containers](https://img.shields.io/static/v1?label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/NomicFoundation/hardhat-ignition.git)
32

43
---
54

0 commit comments

Comments
 (0)