improvement(plugins): use a HH error for duplicate id

Adds a plugin loading duplicate id error under the `general` category
of Hardhat errors and uses that inside `resolve-plugin-list`.

Author: kanej

v-next/core/src/internal/plugins/resolve-plugin-list.ts

@@ -1,3 +1,5 @@
+import { HardhatError } from "@nomicfoundation/hardhat-errors";
+
 import { HardhatPlugin } from "../../types/plugins.js";
 
 /**
@@ -28,8 +30,9 @@ export function reverseTopologicalSort(
 
     if (visited !== undefined) {
       if (visited !== plugin) {
-        throw new Error(
-          `Duplicated plugin id "${plugin.id}" found. Did you install multiple versions of the same plugin?`,
+        throw new HardhatError(
+          HardhatError.ERRORS.GENERAL.DUPLICATED_PLUGIN_ID,
+          { id: plugin.id },
         );
       }
 

v-next/core/test/plugins/resolve-plugin-list.ts

@@ -1,6 +1,8 @@
 import assert from "node:assert";
 import { describe, it } from "node:test";
 
+import { HardhatError } from "@nomicfoundation/hardhat-errors";
+
 import { resolvePluginList } from "../../src/internal/plugins/resolve-plugin-list.js";
 import { HardhatPlugin } from "../../src/types/plugins.js";
 
@@ -106,14 +108,24 @@ describe("Plugins - resolve plugin list", () => {
     ]);
   });
 
-  it("should error on different plugins with the same id", () => {
+  it("should throw a HardhatError on finding different plugins with the same id", () => {
     const a = { id: "dup" };
     const copy = { id: "dup" };
 
     assert.throws(
       () => resolvePluginList([a, copy]),
-      /Duplicated plugin id "dup" found. Did you install multiple versions of the same plugin\?/,
-      "Expected a duplicate is to be detected",
+
+      (err) => {
+        assert(HardhatError.isHardhatError(err), "Expected a HardhatError");
+        assert(
+          /Duplicated plugin id "dup" found. Did you install multiple versions of the same plugin\?/.test(
+            err.message,
+          ),
+        );
+
+        return true;
+      },
+      "Expected a duplicate to be detected",
     );
   });
 });

v-next/hardhat-errors/src/descriptors.ts

@@ -104,6 +104,15 @@ Note that you don't need to do this every time you install a new dependency, but
 
 Please double check the file path.`,
     },
+    DUPLICATED_PLUGIN_ID: {
+      number: 4,
+      messageTemplate:
+        'Duplicated plugin id "%id%" found. Did you install multiple versions of the same plugin?',
+      websiteTitle: "Duplicated plugin id",
+      websiteDescription: `While loading the plugins, two different plugins where found with the same id.
+
+Please double check whether you have multiple versions of the same plugin installed.`,
+    },
   },
   INTERNAL: {
     ASSERTION_ERROR: {