Make sure that solc default import callback is not being used (#4783)

Author: ChristopherDedominici

packages/hardhat-core/src/builtin-tasks/compile.ts

@@ -674,9 +674,26 @@ subtask(TASK_COMPILE_SOLIDITY_RUN_SOLCJS)
 subtask(TASK_COMPILE_SOLIDITY_RUN_SOLC)
   .addParam("input", undefined, undefined, types.any)
   .addParam("solcPath", undefined, undefined, types.string)
+  .addOptionalParam("solcVersion", undefined, undefined, types.string)
   .setAction(
-    async ({ input, solcPath }: { input: CompilerInput; solcPath: string }) => {
-      const compiler = new NativeCompiler(solcPath);
+    async ({
+      input,
+      solcPath,
+      solcVersion,
+    }: {
+      input: CompilerInput;
+      solcPath: string;
+      solcVersion?: string;
+    }) => {
+      if (solcVersion !== undefined && semver.valid(solcVersion) === null) {
+        throw new HardhatError(ERRORS.ARGUMENTS.INVALID_VALUE_FOR_TYPE, {
+          value: solcVersion,
+          name: "solcVersion",
+          type: "string",
+        });
+      }
+
+      const compiler = new NativeCompiler(solcPath, solcVersion);
 
       return compiler.compile(input);
     }
@@ -740,6 +757,7 @@ subtask(TASK_COMPILE_SOLIDITY_COMPILE_SOLC)
         output = await run(TASK_COMPILE_SOLIDITY_RUN_SOLC, {
           input,
           solcPath: solcBuild.compilerPath,
+          solcVersion,
         });
       }
 

packages/hardhat-core/src/internal/solidity/compiler/index.ts

@@ -1,5 +1,8 @@
 import { execFile } from "child_process";
 import * as fs from "fs";
+import os from "node:os";
+import path from "node:path";
+import * as semver from "semver";
 import { CompilerInput, CompilerOutput } from "../../../types";
 import { HardhatError } from "../../core/errors";
 import { ERRORS } from "../../core/errors-list";
@@ -68,14 +71,31 @@ export class Compiler implements ICompiler {
 }
 
 export class NativeCompiler implements ICompiler {
-  constructor(private _pathToSolc: string) {}
+  constructor(private _pathToSolc: string, private _solcVersion?: string) {}
 
   public async compile(input: CompilerInput) {
+    const args = ["--standard-json"];
+
+    // Logic to make sure that solc default import callback is not being used.
+    // If solcVersion is not defined or <= 0.6.8, do not add extra args.
+    if (this._solcVersion !== undefined) {
+      if (semver.gte(this._solcVersion, "0.8.22")) {
+        // version >= 0.8.22
+        args.push("--no-import-callback");
+      } else if (semver.gte(this._solcVersion, "0.6.9")) {
+        // version >= 0.6.9
+        const tmpFolder = path.join(os.tmpdir(), "hardhat-solc");
+        fs.mkdirSync(tmpFolder, { recursive: true });
+        args.push(`--base-path`);
+        args.push(tmpFolder);
+      }
+    }
+
     const output: string = await new Promise((resolve, reject) => {
       try {
         const process = execFile(
           this._pathToSolc,
-          [`--standard-json`],
+          args,
           {
             maxBuffer: 1024 * 1024 * 500,
           },