allow empty arrays as default values for variadic arguments

zoeyTM · zoeyTM · commit 49b2ba3ae758 · 2024-07-10T04:20:53.000-04:00
diff --git a/v-next/core/src/internal/arguments.ts b/v-next/core/src/internal/arguments.ts
@@ -36,7 +36,7 @@ export function isArgumentValueValid(
   const validator = argumentTypeValidators[type];
 
   if (isVariadic) {
-    return Array.isArray(value) && value.length > 0 && value.every(validator);
+    return Array.isArray(value) && value.every(validator);
   }
 
   return validator(value);
diff --git a/v-next/core/test/internal/arguments.ts b/v-next/core/test/internal/arguments.ts
@@ -79,7 +79,7 @@ describe("Arguments", () => {
         isArgumentValueValid(ArgumentType.BIGINT, [123n, BigInt(123)], true),
         true,
       );
-      assert.equal(isArgumentValueValid(ArgumentType.STRING, [], true), false);
+      assert.equal(isArgumentValueValid(ArgumentType.STRING, [], true), true);
       assert.equal(
         isArgumentValueValid(ArgumentType.STRING, ["foo", 123], true),
         false,

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ export function isArgumentValueValid(`
`36`	`36`	`const validator = argumentTypeValidators[type];`
`37`	`37`
`38`	`38`	`if (isVariadic) {`
`39`		`- return Array.isArray(value) && value.length > 0 && value.every(validator);`
	`39`	`+ return Array.isArray(value) && value.every(validator);`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`return validator(value);`