Make task option arguments optional by requiring a defaultValue

Author: schaable

v-next/core/src/internal/tasks/builders.ts

@@ -109,7 +109,7 @@ export class NewTaskDefinitionBuilderImplementation
     name: string;
     description?: string;
     type?: T;
-    defaultValue?: ArgumentTypeToValueType<T>;
+    defaultValue: ArgumentTypeToValueType<T>;
   }): this {
     const argumentType = type ?? ArgumentType.STRING;
 
@@ -131,10 +131,7 @@ export class NewTaskDefinitionBuilderImplementation
       });
     }
 
-    if (
-      defaultValue !== undefined &&
-      !isArgumentValueValid(argumentType, defaultValue)
-    ) {
+    if (!isArgumentValueValid(argumentType, defaultValue)) {
       throw new HardhatError(
         HardhatError.ERRORS.TASK_DEFINITIONS.INVALID_VALUE_FOR_TYPE,
         {
@@ -342,7 +339,7 @@ export class TaskOverrideDefinitionBuilderImplementation
     name: string;
     description?: string;
     type?: T;
-    defaultValue?: ArgumentTypeToValueType<T>;
+    defaultValue: ArgumentTypeToValueType<T>;
   }): this {
     const argumentType = type ?? ArgumentType.STRING;
 
@@ -364,10 +361,7 @@ export class TaskOverrideDefinitionBuilderImplementation
       });
     }
 
-    if (
-      defaultValue !== undefined &&
-      !isArgumentValueValid(argumentType, defaultValue)
-    ) {
+    if (!isArgumentValueValid(argumentType, defaultValue)) {
       throw new HardhatError(
         HardhatError.ERRORS.TASK_DEFINITIONS.INVALID_VALUE_FOR_TYPE,
         {

v-next/core/src/types/tasks.ts

@@ -45,7 +45,7 @@ export interface TaskArgumentDefinition<T extends ArgumentType = ArgumentType> {
  */
 export interface TaskOptionDefinition<T extends ArgumentType = ArgumentType>
   extends TaskArgumentDefinition<T> {
-  defaultValue?: ArgumentTypeToValueType<T>;
+  defaultValue: ArgumentTypeToValueType<T>;
 }
 
 /**
@@ -201,14 +201,13 @@ export interface NewTaskDefinitionBuilder {
    *
    * The type of the argument defaults to `ArgumentType.STRING`.
    *
-   * The default value, if provided, should be of the same type as the
-   * argument.
+   * The default value should be of the same type as the argument.
    */
   addOption<T extends ArgumentType>(optionConfig: {
     name: string;
     description?: string;
     type?: T;
-    defaultValue?: ArgumentTypeToValueType<T>;
+    defaultValue: ArgumentTypeToValueType<T>;
   }): this;
 
   /**
@@ -291,7 +290,7 @@ export interface TaskOverrideDefinitionBuilder {
     name: string;
     description?: string;
     type?: T;
-    defaultValue?: ArgumentTypeToValueType<T>;
+    defaultValue: ArgumentTypeToValueType<T>;
   }): this;
 
   /**