Merge pull request #4791 from NomicFoundation/sourcify-programmatic-access

Add support for programmatic verification in Sourcify

Author: schaable

.changeset/twelve-mails-heal.md

@@ -0,0 +1,5 @@
+---
+"@nomicfoundation/hardhat-verify": patch
+---
+
+Added support for programmatic verification in Sourcify

packages/hardhat-verify/src/index.ts

@@ -259,9 +259,7 @@ subtask(TASK_VERIFY_GET_CONTRACT_INFORMATION)
   );
 
 /**
- * This subtask is used for backwards compatibility.
- * TODO [remove-verify-subtask]: if you're going to remove this subtask,
- * update TASK_VERIFY_ETHERSCAN and TASK_VERIFY_ETHERSCAN_RESOLVE_ARGUMENTS accordingly
+ * This subtask is used to programmatically verify a contract on Etherscan or Sourcify.
  */
 subtask(TASK_VERIFY_VERIFY)
   .addOptionalParam("address")
@@ -271,7 +269,7 @@ subtask(TASK_VERIFY_VERIFY)
   .setAction(
     async (
       { address, constructorArguments, libraries, contract }: VerifySubtaskArgs,
-      { run }
+      { run, config }
     ) => {
       // This can only happen if the subtask is invoked from within Hardhat by a user script or another task.
       if (!Array.isArray(constructorArguments)) {
@@ -282,11 +280,21 @@ subtask(TASK_VERIFY_VERIFY)
         throw new InvalidLibrariesError();
       }
 
-      await run(TASK_VERIFY_ETHERSCAN, {
-        address,
-        constructorArgsParams: constructorArguments,
-        libraries,
-        contract,
-      });
+      if (config.etherscan.enabled) {
+        await run(TASK_VERIFY_ETHERSCAN, {
+          address,
+          constructorArgsParams: constructorArguments,
+          libraries,
+          contract,
+        });
+      }
+
+      if (config.sourcify.enabled) {
+        await run(TASK_VERIFY_SOURCIFY, {
+          address,
+          libraries,
+          contract,
+        });
+      }
     }
   );

packages/hardhat-verify/src/internal/tasks/etherscan.ts

@@ -74,7 +74,6 @@ subtask(TASK_VERIFY_ETHERSCAN)
   .addParam("address")
   .addOptionalParam("constructorArgsParams", undefined, undefined, types.any)
   .addOptionalParam("constructorArgs")
-  // TODO: [remove-verify-subtask] change to types.inputFile
   .addOptionalParam("libraries", undefined, undefined, types.any)
   .addOptionalParam("contract")
   .setAction(async (taskArgs: VerifyTaskArgs, { config, network, run }) => {
@@ -199,7 +198,6 @@ subtask(TASK_VERIFY_ETHERSCAN_RESOLVE_ARGUMENTS)
   .addOptionalParam("address")
   .addOptionalParam("constructorArgsParams", undefined, [], types.any)
   .addOptionalParam("constructorArgs", undefined, undefined, types.inputFile)
-  // TODO: [remove-verify-subtask] change to types.inputFile
   .addOptionalParam("libraries", undefined, undefined, types.any)
   .addOptionalParam("contract")
   .setAction(
@@ -228,7 +226,6 @@ subtask(TASK_VERIFY_ETHERSCAN_RESOLVE_ARGUMENTS)
         constructorArgsModule
       );
 
-      // TODO: [remove-verify-subtask] librariesModule should always be string
       let libraries;
       if (typeof librariesModule === "object") {
         libraries = librariesModule;

packages/hardhat-verify/src/internal/tasks/sourcify.ts

@@ -51,7 +51,6 @@ interface AttemptVerificationArgs {
 subtask(TASK_VERIFY_SOURCIFY)
   .addParam("address")
   .addOptionalParam("contract")
-  // TODO: [remove-verify-subtask] change to types.inputFile
   .addOptionalParam("libraries", undefined, undefined, types.any)
   .setAction(async (taskArgs: VerifyTaskArgs, { config, network, run }) => {
     const { address, libraries, contractFQN }: VerificationArgs = await run(
@@ -143,7 +142,6 @@ ${contractURL}`);
 subtask(TASK_VERIFY_SOURCIFY_RESOLVE_ARGUMENTS)
   .addOptionalParam("address")
   .addOptionalParam("contract")
-  // TODO: [remove-verify-subtask] change to types.inputFile
   .addOptionalParam("libraries", undefined, undefined, types.any)
   .setAction(
     async ({
@@ -164,7 +162,6 @@ subtask(TASK_VERIFY_SOURCIFY_RESOLVE_ARGUMENTS)
         throw new InvalidContractNameError(contract);
       }
 
-      // TODO: [remove-verify-subtask] librariesModule should always be string
       let libraries;
       if (typeof librariesModule === "object") {
         libraries = librariesModule;