Add eslint-plugin-mocha

Also: replace eslint-plugin-no-only-tests with the no-exclusive-tests
rule of this plugin

Author: fvictorio

config/eslint/eslintrc.js

@@ -12,7 +12,7 @@ module.exports = {
   plugins: [
     "@nomicfoundation/hardhat-internal-rules",
     "import",
-    "no-only-tests",
+    "mocha",
     "@typescript-eslint",
     "@nomicfoundation/slow-imports",
   ],
@@ -206,7 +206,6 @@ module.exports = {
     "no-extra-bind": "error",
     "no-new-func": "error",
     "no-new-wrappers": "error",
-    "no-only-tests/no-only-tests": "error",
     "no-return-await": "off",
     "@typescript-eslint/return-await": "error",
     "no-sequences": "error",
@@ -238,5 +237,7 @@ module.exports = {
         patterns: ["hardhat/src", "@nomiclabs/*/src"],
       },
     ],
+    "mocha/no-exclusive-tests": "error",
+    "mocha/no-async-describe": "error",
   },
 };

packages/hardhat-chai-matchers/package.json

@@ -55,7 +55,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "ethers": "^6.1.0",
     "get-port": "^5.1.1",

packages/hardhat-core/package.json

@@ -92,7 +92,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "ethers": "^6.1.0",
     "ethers-v5": "npm:ethers@5",

packages/hardhat-core/test/internal/hardhat-network/stack-traces/test.ts

@@ -153,7 +153,7 @@ function defineTest(
   ) {
     it.skip(desc, func);
   } else if (testDefinition.only !== undefined && testDefinition.only) {
-    // eslint-disable-next-line no-only-tests/no-only-tests
+    // eslint-disable-next-line mocha/no-exclusive-tests
     it.only(desc, func);
   } else {
     it(desc, func);
@@ -773,7 +773,7 @@ describe("Stack traces", function () {
       process.exit(1);
     }
 
-    // eslint-disable-next-line no-only-tests/no-only-tests
+    // eslint-disable-next-line mocha/no-exclusive-tests
     describe.only(`Use compiler at ${customSolcPath} with version ${customSolcVersion}`, function () {
       const compilerOptions = {
         solidityVersion: customSolcVersion,
@@ -867,7 +867,7 @@ function defineTestForSolidityMajorVersion(
   testsPath: string
 ) {
   for (const compilerOptions of solcVersionsCompilerOptions) {
-    // eslint-disable-next-line no-only-tests/no-only-tests
+    // eslint-disable-next-line mocha/no-exclusive-tests
     const describeFn = compilerOptions.only === true ? describe.only : describe;
 
     describeFn(`Use compiler ${compilerOptions.compilerPath}`, function () {

packages/hardhat-ethers/package.json

@@ -61,7 +61,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "ethers": "^6.1.0",
     "hardhat": "workspace:^2.0.0",

packages/hardhat-foundry/package.json

@@ -48,6 +48,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.17.2",
     "mocha": "^10.0.0",

packages/hardhat-ledger/package.json

@@ -63,7 +63,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.16.0",
     "mocha": "^10.0.0",

packages/hardhat-network-helpers/package.json

@@ -55,7 +55,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "ethers-v5": "npm:ethers@5",
     "hardhat": "workspace:^2.9.5",

packages/hardhat-shorthand/package.json

@@ -49,7 +49,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.0.0",
     "mocha": "^10.0.0",

packages/hardhat-solhint/package.json

@@ -52,7 +52,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "fs-extra": "^7.0.1",
     "hardhat": "workspace:^2.0.0",

packages/hardhat-solpp/package.json

@@ -52,7 +52,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.0.0",
     "mocha": "^10.0.0",

packages/hardhat-toolbox-viem/package.json

@@ -59,7 +59,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.11.0",
     "hardhat-gas-reporter": "^1.0.8",

packages/hardhat-toolbox/package.json

@@ -58,7 +58,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "ethers": "^6.4.0",
     "hardhat": "workspace:^2.11.0",

packages/hardhat-truffle4/package.json

@@ -55,7 +55,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.6.4",
     "mocha": "^10.0.0",

packages/hardhat-truffle5/package.json

@@ -55,7 +55,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.6.4",
     "mocha": "^10.0.0",

packages/hardhat-verify/package.json

@@ -70,7 +70,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "ethers": "^5.0.0",
     "hardhat": "workspace:^2.0.4",

packages/hardhat-viem/package.json

@@ -55,7 +55,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.17.0",
     "jest-diff": "^29.7.0",

packages/hardhat-vyper/package.json

@@ -58,7 +58,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.8.3",
     "mocha": "^10.0.0",

packages/hardhat-web3-legacy/package.json

@@ -46,7 +46,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.0.0",
     "mocha": "^10.0.0",

packages/hardhat-web3-v4/package.json

@@ -47,7 +47,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.0.0",
     "mocha": "^10.0.0",

packages/hardhat-web3/package.json

@@ -46,7 +46,7 @@
     "eslint": "^8.44.0",
     "eslint-config-prettier": "8.3.0",
     "eslint-plugin-import": "2.27.5",
-    "eslint-plugin-no-only-tests": "3.0.0",
+    "eslint-plugin-mocha": "10.4.1",
     "eslint-plugin-prettier": "3.4.0",
     "hardhat": "workspace:^2.0.0",
     "mocha": "^10.0.0",