Skip to content

Commit 6bee060

Browse files
authored
fix: don't build edr_napi before testing in CI (#4888)
1 parent e04b0cb commit 6bee060

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

.github/workflows/edr-npm-release.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
- host: windows-latest
3838
build: |
3939
pnpm build --target i686-pc-windows-msvc
40-
pnpm test
40+
pnpm testNoBuild
4141
target: i686-pc-windows-msvc
4242
- host: ubuntu-latest
4343
target: x86_64-unknown-linux-gnu
@@ -202,7 +202,7 @@ jobs:
202202
run: ls -R .
203203
shell: bash
204204
- name: Test bindings
205-
run: pnpm test
205+
run: pnpm testNoBuild
206206
test-linux-x64-gnu-binding:
207207
name: Test bindings on Linux-x64-gnu - node@${{ matrix.node }}
208208
needs:
@@ -236,7 +236,7 @@ jobs:
236236
run: ls -R .
237237
shell: bash
238238
- name: Test bindings
239-
run: docker run --rm -v $(pwd):/build -w /build/crates/edr_napi node:${{ matrix.node }} bash -c "wget -qO- 'https://unpkg.com/@pnpm/self-installer' | node; pnpm test"
239+
run: docker run --rm -v $(pwd):/build -w /build/crates/edr_napi node:${{ matrix.node }} bash -c "wget -qO- 'https://unpkg.com/@pnpm/self-installer' | node; pnpm testNoBuild"
240240
test-linux-x64-musl-binding:
241241
name: Test bindings on x86_64-unknown-linux-musl - node@${{ matrix.node }}
242242
needs:
@@ -272,7 +272,7 @@ jobs:
272272
run: ls -R .
273273
shell: bash
274274
- name: Test bindings
275-
run: docker run --rm -v $(pwd):/build -w /build/crates/edr_napi node:${{ matrix.node }}-alpine sh -c "wget -qO- 'https://unpkg.com/@pnpm/self-installer' | node; pnpm test"
275+
run: docker run --rm -v $(pwd):/build -w /build/crates/edr_napi node:${{ matrix.node }}-alpine sh -c "wget -qO- 'https://unpkg.com/@pnpm/self-installer' | node; pnpm testNoBuild"
276276
test-linux-aarch64-gnu-binding:
277277
name: Test bindings on aarch64-unknown-linux-gnu - node@${{ matrix.node }}
278278
needs:
@@ -315,7 +315,7 @@ jobs:
315315
run: |
316316
wget -qO- 'https://unpkg.com/@pnpm/self-installer' | node
317317
set -e
318-
pnpm test
318+
pnpm testNoBuild
319319
ls -la
320320
test-linux-aarch64-musl-binding:
321321
name: Test bindings on aarch64-unknown-linux-musl - node@lts
@@ -353,7 +353,7 @@ jobs:
353353
run: |
354354
wget -qO- 'https://unpkg.com/@pnpm/self-installer' | node
355355
set -e
356-
pnpm test
356+
pnpm testNoBuild
357357
check_commit:
358358
name: Check commit
359359
runs-on: ubuntu-latest

crates/edr_napi/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
"version": "napi version",
4646
"pretest": "pnpm build",
4747
"test": "pnpm tsc && mocha --recursive \"test/**/*.ts\" --exit",
48+
"testNoBuild": "pnpm tsc && mocha --recursive \"test/**/*.ts\" --exit",
4849
"clean": "rm -rf @ignored/edr.node"
4950
}
5051
}

0 commit comments

Comments
 (0)