Explicitly use the constant rather than state in ConsoleLogger

Author: Xanewok

packages/hardhat-core/scripts/console-library-generator.ts

@@ -80,9 +80,8 @@ library console {
 `;
 
 logger +=
-  "\n// In order to optimize map lookup\n" +
-  "// we'll store 4byte signature as int\n" +
-  "export const ConsoleLogs = {\n";
+  "\n/** Maps from a 4-byte function selector to a signature (argument types) */\n" +
+  "export const CONSOLE_LOG_SIGNATURES: Record<number, string[]> = {\n";
 
 // Add the empty log() first
 const sigInt = bytesToInt(keccak256(Buffer.from("log" + "()")).slice(0, 4));

packages/hardhat-core/src/internal/hardhat-network/stack-traces/consoleLogger.ts

@@ -42,10 +42,10 @@ import {
   Bytes8Ty,
   Bytes9Ty,
   BytesTy,
-  ConsoleLogs,
   Int256Ty,
   StringTy,
   Uint256Ty,
+  CONSOLE_LOG_SIGNATURES,
 } from "./logger";
 import {
   EvmMessageTrace,
@@ -67,14 +67,6 @@ export type ConsoleLogEntry = string | ConsoleLogArray;
 export type ConsoleLogs = ConsoleLogEntry[];
 
 export class ConsoleLogger {
-  private readonly _consoleLogs: {
-    [key: number]: string[];
-  } = {};
-
-  constructor() {
-    this._consoleLogs = ConsoleLogs;
-  }
-
   public getLogMessages(maybeDecodedMessageTrace: MessageTrace): string[] {
     return this.getExecutionLogs(maybeDecodedMessageTrace).map(
       consoleLogToString
@@ -132,15 +124,15 @@ export class ConsoleLogger {
   }
 
   private _maybeConsoleLog(calldata: Buffer): ConsoleLogs | undefined {
-    const sig = bytesToInt(calldata.slice(0, 4));
+    const selector = bytesToInt(calldata.slice(0, 4));
     const parameters = calldata.slice(4);
 
-    const types = this._consoleLogs[sig];
-    if (types === undefined) {
+    const argTypes = CONSOLE_LOG_SIGNATURES[selector];
+    if (argTypes === undefined) {
       return;
     }
 
-    const consoleLogs = this._decode(parameters, types);
+    const consoleLogs = this._decode(parameters, argTypes);
 
     this._replaceNumberFormatSpecifiers(consoleLogs);
 

packages/hardhat-core/src/internal/hardhat-network/stack-traces/logger.ts

@@ -42,9 +42,8 @@ export const Bytes30Ty = "Bytes30";
 export const Bytes31Ty = "Bytes31";
 export const Bytes32Ty = "Bytes32";
 
-// In order to optimize map lookup
-// we'll store 4byte signature as int
-export const ConsoleLogs = {
+/** Maps from a 4-byte function selector to a signature (argument types) */
+export const CONSOLE_LOG_SIGNATURES: Record<number, string[]> = {
   1368866505: [],
   760966329: [Int256Ty],
   1309416733: [Int256Ty],