some adjustments

Author: RenanSouza2

packages/hardhat-chai-matchers/src/internal/emit.ts

@@ -166,12 +166,11 @@ function assertArgsArraysEqual(
     actualArgs.length === expectedArgs.length,
     `Expected "${eventName}" event to have ${expectedArgs.length} argument(s), but it has ${actualArgs.length}`
   );
-  for (const index in expectedArgs) {
-    const expectedArg = expectedArgs[index];
+  for (const [index, expectedArg] of expectedArgs.entries()) {
     const actualArg = actualArgs[index];
     if (typeof expectedArg === "function") {
       const errorPrefix = `The predicate for the ${ordinal(
-        parseInt(index) + 1
+        index + 1
       )} event argument`;
       try {
         if (expectedArg(actualArg) === true) continue;
@@ -185,7 +184,7 @@ function assertArgsArraysEqual(
       }
       assert(
         false,
-        `${errorPrefix} returned false`
+        `${errorPrefix} did not return true `
         // no need for a negated message, since we disallow mixing .not. with
         // .withArgs
       );
@@ -202,7 +201,7 @@ function assertArgsArraysEqual(
       assert(
         expectedLength === actualLength,
         `Expected the ${ordinal(
-          parseInt(index) + 1
+          index + 1
         )} argument of the "${eventName}" event to have ${expectedLength} ${
           expectedLength === 1 ? "element" : "elements"
         }, but it has ${actualLength}`
@@ -214,16 +213,8 @@ function assertArgsArraysEqual(
         );
       }
     } else {
-      if (
-        actualArg.hash !== undefined &&
-        actualArg._isIndexed === true
-      ) {
-        new Assertion(
-          actualArg.hash,
-          undefined,
-          ssfi,
-          true
-        ).to.not.equal(
+      if (actualArg.hash !== undefined && actualArg._isIndexed === true) {
+        new Assertion(actualArg.hash, undefined, ssfi, true).to.not.equal(
           expectedArg,
           "The actual value was an indexed and hashed value of the event argument. The expected value provided to the assertion should be the actual event argument (the pre-image of the hash). You provided the hash itself. Please supply the actual event argument (the pre-image of the hash) instead."
         );
@@ -236,9 +227,7 @@ function assertArgsArraysEqual(
           `The actual value was an indexed and hashed value of the event argument. The expected value provided to the assertion was hashed to produce ${expectedHash}. The actual hash and the expected hash did not match`
         );
       } else {
-        new Assertion(actualArg, undefined, ssfi, true).equal(
-          expectedArg
-        );
+        new Assertion(actualArg, undefined, ssfi, true).equal(expectedArg);
       }
     }
   }

packages/hardhat-chai-matchers/test/events.ts

@@ -22,17 +22,15 @@ describe(".to.emit (contract events)", () => {
     runTests();
   });
 
-  describe("connected to a hardhat node", function () {
+  describe.only("connected to a hardhat node", function () {
     useEnvironmentWithNode("hardhat-project");
 
     runTests();
   });
 
   function runTests() {
     beforeEach(async function () {
-      otherContract = await (
-        await this.hre.ethers.getContractFactory("AnotherContract")
-      ).deploy();
+      otherContract = await this.hre.ethers.deployContract("AnotherContract");
 
       contract = await (
         await this.hre.ethers.getContractFactory<[string], EventsContract>(
@@ -66,7 +64,9 @@ describe(".to.emit (contract events)", () => {
     });
 
     it("Should detect events without arguments", async function () {
-      await expect(contract.emitWithoutArgs()).to.emit(contract, "WithoutArgs");
+      await expect(contract.emitWithoutArgs())
+        .to.emit(contract, "WithoutArgs")
+        .withArgs();
     });
 
     it("Should fail when expecting an event that wasn't emitted", async function () {
@@ -538,7 +538,7 @@ describe(".to.emit (contract events)", () => {
                 .withArgs(1, () => false)
             ).to.be.eventually.rejectedWith(
               AssertionError,
-              "The predicate for the 2nd event argument returned false"
+              "The predicate for the 2nd event argument did not return true"
             );
           });