update imports and fix redundant testing

Author: zoeyTM

v-next/hardhat/src/internal/builtin-plugins/run/index.ts

@@ -2,8 +2,6 @@ import type { HardhatPlugin } from "@nomicfoundation/hardhat-core/types/plugins"
 
 import { ParameterType, task } from "@nomicfoundation/hardhat-core/config";
 
-import { runScriptWithHardhat } from "./runScriptWithHardhat.js";
-
 export default {
   id: "run",
   tasks: [
@@ -17,7 +15,7 @@ export default {
         name: "noCompile",
         description: "Don't compile before running this task",
       })
-      .setAction(runScriptWithHardhat)
+      .setAction(import.meta.resolve("./runScriptWithHardhat.js"))
       .build(),
   ],
 } satisfies HardhatPlugin;

v-next/hardhat/src/internal/builtin-plugins/run/runScriptWithHardhat.ts

@@ -9,7 +9,7 @@ import {
 } from "@nomicfoundation/hardhat-errors";
 import { exists } from "@nomicfoundation/hardhat-utils/fs";
 
-export const runScriptWithHardhat: NewTaskActionFunction = async (
+const runScriptWithHardhat: NewTaskActionFunction = async (
   { script, noCompile },
   _hre,
 ) => {
@@ -55,3 +55,5 @@ export const runScriptWithHardhat: NewTaskActionFunction = async (
     throw error;
   }
 };
+
+export default runScriptWithHardhat;

v-next/hardhat/test/src/internal/builtin-plugins/run/runScriptWIthHardhat.ts

@@ -6,7 +6,7 @@ import { before, describe, it } from "node:test";
 import { createHardhatRuntimeEnvironment } from "@nomicfoundation/hardhat-core";
 import { HardhatError } from "@nomicfoundation/hardhat-errors";
 
-import { runScriptWithHardhat } from "../../../../../src/internal/builtin-plugins/run/runScriptWithHardhat.js";
+import runScriptWithHardhat from "../../../../../src/internal/builtin-plugins/run/runScriptWithHardhat.js";
 import { useFixtureProject } from "../../../../helpers/project.js";
 
 describe("runScriptWithHardhat", function () {
@@ -17,28 +17,28 @@ describe("runScriptWithHardhat", function () {
   });
 
   it("should throw if script is not a string", async function () {
-    await assert.rejects(async () => {
-      await runScriptWithHardhat({ script: 123, noCompile: false }, hre);
-    }, /An internal invariant was violated: Expected script to be a string/);
+    await assert.rejects(
+      runScriptWithHardhat({ script: 123, noCompile: false }, hre),
+      /An internal invariant was violated: Expected script to be a string/,
+    );
   });
 
   it("should throw if noCompile is not a boolean", async function () {
-    await assert.rejects(async () => {
-      await runScriptWithHardhat({ script: "script.js", noCompile: 123 }, hre);
-    }, /An internal invariant was violated: Expected noCompile to be a boolean/);
+    await assert.rejects(
+      runScriptWithHardhat({ script: "script.js", noCompile: 123 }, hre),
+      /An internal invariant was violated: Expected noCompile to be a boolean/,
+    );
   });
 
   describe("javascript", function () {
     useFixtureProject("run-js-script");
 
     it("should throw if script does not exist", async function () {
       await assert.rejects(
-        async () => {
-          await runScriptWithHardhat(
-            { script: "./scripts/non-existent.js", noCompile: false },
-            hre,
-          );
-        },
+        runScriptWithHardhat(
+          { script: "./scripts/non-existent.js", noCompile: false },
+          hre,
+        ),
         new HardhatError(HardhatError.ERRORS.BUILTIN_TASKS.RUN_FILE_NOT_FOUND, {
           script: "./scripts/non-existent.js",
         }),
@@ -54,12 +54,10 @@ describe("runScriptWithHardhat", function () {
 
     it("should throw if the script throws", async function () {
       await assert.rejects(
-        async () => {
-          await runScriptWithHardhat(
-            { script: "./scripts/throws.js", noCompile: false },
-            hre,
-          );
-        },
+        runScriptWithHardhat(
+          { script: "./scripts/throws.js", noCompile: false },
+          hre,
+        ),
         new HardhatError(HardhatError.ERRORS.BUILTIN_TASKS.RUN_SCRIPT_ERROR, {
           script: "./scripts/throws.js",
           error: "broken script",
@@ -73,12 +71,10 @@ describe("runScriptWithHardhat", function () {
 
     it("should throw if script does not exist", async function () {
       await assert.rejects(
-        async () => {
-          await runScriptWithHardhat(
-            { script: "./scripts/non-existent.ts", noCompile: false },
-            hre,
-          );
-        },
+        runScriptWithHardhat(
+          { script: "./scripts/non-existent.ts", noCompile: false },
+          hre,
+        ),
         new HardhatError(HardhatError.ERRORS.BUILTIN_TASKS.RUN_FILE_NOT_FOUND, {
           script: "./scripts/non-existent.ts",
         }),
@@ -94,12 +90,10 @@ describe("runScriptWithHardhat", function () {
 
     it("should throw if the script throws", async function () {
       await assert.rejects(
-        async () => {
-          await runScriptWithHardhat(
-            { script: "./scripts/throws.ts", noCompile: false },
-            hre,
-          );
-        },
+        runScriptWithHardhat(
+          { script: "./scripts/throws.ts", noCompile: false },
+          hre,
+        ),
         new HardhatError(HardhatError.ERRORS.BUILTIN_TASKS.RUN_SCRIPT_ERROR, {
           script: "./scripts/throws.ts",
           error: "broken script",