Throw if trying to resolve an npm root with incorrect casing

Author: alcuadrado

v-next/hardhat-errors/src/descriptors.ts

@@ -1122,6 +1122,12 @@ Please try renaming the directory.`,
       websiteTitle: "Resolution of non-existent npm file",
       websiteDescription: `You are tying to resolve an npm file that doesn't exist within its package.`,
     },
+    RESOLVE_WRONG_CASING_NPM_FILE: {
+      number: 1224,
+      messageTemplate: `You are tying to resolve the npm file "{module}", its casing is incorrect.`,
+      websiteTitle: "Resolution of npm file with incorrect casing",
+      websiteDescription: `You are tying to resolve an npm file whose casing is incorrect.`,
+    },
     DOWNLOAD_FAILED: {
       number: 1225,
       messageTemplate:

v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/resolver/dependency-resolver.ts

@@ -306,21 +306,25 @@ export class ResolverImplementation implements Resolver {
         );
       }
 
-      // Just like with the project files, we are more forgiving with the casing
-      // here, as this is not used for imports.
+      if (resolvedSubpath !== trueCaseFsPath) {
+        throw new HardhatError(
+          HardhatError.ERRORS.SOLIDITY.RESOLVE_WRONG_CASING_NPM_FILE,
+          { module: npmModule },
+        );
+      }
 
       const sourceName = sourceNamePathJoin(
         npmPackageToRootSourceName(npmPackage.name, npmPackage.version),
+        // We use the subpath (pre-resolution) to create source names
         fsPathToSourceNamePath(subpath),
       );
 
-      const resolvedWithTheRightCasing =
-        this.#resolvedFileBySourceName.get(sourceName);
+      const resolved = this.#resolvedFileBySourceName.get(sourceName);
 
-      if (resolvedWithTheRightCasing !== undefined) {
+      if (resolved !== undefined) {
         /* eslint-disable-next-line @typescript-eslint/consistent-type-assertions
       -- If it was, it's a ProjectResolvedFile */
-        return resolvedWithTheRightCasing as NpmPackageResolvedFile;
+        return resolved as NpmPackageResolvedFile;
       }
 
       const fsPath = path.join(npmPackage.rootFsPath, trueCaseFsPath);