Merge pull request #5199 from fwx5618177/feat/checkConstructorArgsType

feat: check check constructor args type

Author: schaable

.changeset/thick-beers-tie.md

@@ -0,0 +1,5 @@
+---
+"@nomicfoundation/hardhat-verify": patch
+---
+
+Improved validation of contructor arguments (thanks @fwx5618177!)

packages/hardhat-verify/src/internal/utilities.ts

@@ -19,6 +19,7 @@ import {
 
 import { LibraryToAddress } from "./solc/artifacts";
 import {
+  ABIArgumentTypeErrorType,
   isABIArgumentLengthError,
   isABIArgumentOverflowError,
   isABIArgumentTypeError,
@@ -228,6 +229,24 @@ export async function encodeArguments(
   const contractInterface = new Interface(abi);
   let encodedConstructorArguments;
   try {
+    // encodeDeploy doesn't catch subtle type mismatches, such as a number
+    // being passed when a string is expected, so we have to validate the
+    // scenario manually.
+    const expectedConstructorArgs = contractInterface.deploy.inputs;
+    constructorArguments.forEach((arg, i) => {
+      if (
+        expectedConstructorArgs[i]?.type === "string" &&
+        typeof arg !== "string"
+      ) {
+        throw new ABIArgumentTypeError({
+          code: "INVALID_ARGUMENT",
+          argument: expectedConstructorArgs[i].name,
+          value: arg,
+          reason: "invalid string value",
+        } as ABIArgumentTypeErrorType);
+      }
+    });
+
     encodedConstructorArguments = contractInterface
       .encodeDeploy(constructorArguments)
       .replace("0x", "");

packages/hardhat-verify/test/unit/utilities.ts

@@ -537,6 +537,39 @@ but 2 arguments were provided instead.`);
       );
     });
 
+    it("should throw if a parameter type does not match its expected type: number instead of string", async () => {
+      const abi: JsonFragment[] = [
+        {
+          inputs: [
+            {
+              name: "amount",
+              type: "uint256",
+            },
+            {
+              name: "amount",
+              type: "string",
+            },
+            {
+              name: "amount",
+              type: "address",
+            },
+          ],
+          stateMutability: "nonpayable",
+          type: "constructor",
+        },
+      ];
+      const constructorArguments: any[] = [
+        50,
+        50, // Invalid string
+        "0x752C8191E6b1Db38B41A8c8921F7a703F2969d18",
+      ];
+      await expect(
+        encodeArguments(abi, sourceName, contractName, constructorArguments)
+      ).to.be.rejectedWith(
+        /Value 50 cannot be encoded for the parameter amount./
+      );
+    });
+
     it("should throw if an unsafe integer is provided as an argument", async () => {
       const abi: JsonFragment[] = [
         {