Skip to content

Commit b49e663

Browse files
committed
chore: clean up
There are 3 moves here: - Remove the pushing of tags - Move the if check to the job level rather than per step - temporarily comment out the git push
1 parent 69f1e92 commit b49e663

File tree

3 files changed

+4
-21
lines changed

3 files changed

+4
-21
lines changed

.github/workflows/v-next-changesets-release.yml

+2-19
Original file line numberDiff line numberDiff line change
@@ -39,54 +39,37 @@ jobs:
3939
name: Release
4040
runs-on: ubuntu-latest
4141
needs: changesetcheck
42+
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
4243
permissions:
4344
contents: write
4445
id-token: write
4546
steps:
46-
- name: Stop on no changesets
47-
if: needs.changesetcheck.outputs.CHANGESETS == 'notfound'
48-
run: |
49-
echo "No changesets found. Exiting the workflow."
50-
exit 0
51-
5247
- name: checkout code repository
5348
uses: actions/checkout@v4
54-
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
5549
with:
5650
fetch-depth: 0
5751
- uses: pnpm/action-setup@v4
58-
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
5952
with:
6053
version: 9
6154
- uses: actions/setup-node@v4
62-
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
6355
with:
6456
node-version: 22
6557
cache: "pnpm"
6658
- name: Install
67-
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
6859
run: pnpm install --no-frozen-lockfile
6960
- name: Apply and commit changesets
70-
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
7161
run: |
7262
echo "Changesets found. Starting release."
7363
pnpm changeset version
7464
git config --global user.name "Github Actions"
7565
git config --global user.email "[email protected]"
7666
git commit -a -m "chore: v-next version bump"
77-
git push
67+
# git push
7868
env:
7969
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8070
- name: Setup npmrc
81-
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
8271
run: echo "//registry.npmjs.org/:_authToken=${{ secrets.VNEXT_NPM_TOKEN }}" > .npmrc
8372
- name: Publish
84-
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
8573
run: pnpm publish --filter "./v-next/**" -r --no-git-checks --tag next --access public --dry-run
8674
env:
8775
NPM_CONFIG_PROVENANCE: true
88-
- name: push tags
89-
if: needs.changesetcheck.outputs.CHANGESETS == 'found'
90-
run: git push --follow-tags
91-
env:
92-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

v-next/hardhat/test/fixture-projects/run-js-script/hardhat.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { task } from "@nomicfoundation/hardhat/config";
1+
import { task } from "@ignored/hardhat-vnext/config";
22

33
export default {
44
tasks: [

v-next/hardhat/test/fixture-projects/run-js-script/scripts/success.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import hre from "@nomicfoundation/hardhat";
1+
import hre from "@ignored/hardhat-vnext";
22

33
if (!hre.tasks.rootTasks.has("test")) {
44
throw new Error("test task not found");

0 commit comments

Comments
 (0)