Smaller fixes based on the PR's comments

Author: ChristopherDedominici

v-next/hardhat/src/internal/cli/telemetry/analytics/analytics.ts

@@ -79,6 +79,10 @@ async function sendAnalytics(
 async function createSubprocessToSendAnalytics(
   payload: TelemetryConsentPayload | Payload,
 ): Promise<void> {
+  // The HARDHAT_TEST_SUBPROCESS_RESULT_PATH env variable is used in the tests to instruct the subprocess to write the payload to a file
+  // instead of sending it.
+  // During testing, the subprocess file is a ts file, whereas in production, it is a js file (compiled code).
+  // The following lines adjust the file extension based on whether the environment is for testing or production.
   const fileExt =
     process.env.HARDHAT_TEST_SUBPROCESS_RESULT_PATH !== undefined ? "ts" : "js";
   const subprocessFile = `${import.meta.dirname}/subprocess.${fileExt}`;

v-next/hardhat/src/internal/cli/telemetry/analytics/subprocess.ts

@@ -2,26 +2,21 @@ import { writeJsonFile } from "@ignored/hardhat-vnext-utils/fs";
 import { postJsonRequest } from "@ignored/hardhat-vnext-utils/request";
 
 // These keys are expected to be public
+// TODO: replace with prod values
 const ANALYTICS_URL = "https://www.google-analytics.com/mp/collect";
 const API_SECRET = "iXzTRik5RhahYpgiatSv1w";
 const MEASUREMENT_ID = "G-ZFZWHGZ64H";
 
-async function main(): Promise<void> {
-  const payload = JSON.parse(process.argv[2]);
-
-  if (process.env.HARDHAT_TEST_SUBPROCESS_RESULT_PATH === undefined) {
-    await postJsonRequest(ANALYTICS_URL, payload, {
-      queryParams: {
-        api_secret: API_SECRET,
-        measurement_id: MEASUREMENT_ID,
-      },
-    });
-
-    return;
-  }
+const payload = JSON.parse(process.argv[2]);
 
+if (process.env.HARDHAT_TEST_SUBPROCESS_RESULT_PATH === undefined) {
+  await postJsonRequest(ANALYTICS_URL, payload, {
+    queryParams: {
+      api_secret: API_SECRET,
+      measurement_id: MEASUREMENT_ID,
+    },
+  });
+} else {
   // ATTENTION: only for testing
   await writeJsonFile(process.env.HARDHAT_TEST_SUBPROCESS_RESULT_PATH, payload);
 }
-
-await main();

v-next/hardhat/src/internal/cli/telemetry/telemetry-permissions.ts

@@ -62,7 +62,7 @@ export async function isTelemetryAllowed(): Promise<boolean> {
 /**
  * Determines if telemetry is allowed in the current environment.
  * This function checks various environmental factors to decide if telemetry data can be collected.
- * It verifies that the environment is not a continuous integration (CI) environment, that the terminal is interactive,
+ * It verifies that the environment is not a CI environment, that the terminal is interactive,
  * and that telemetry has not been explicitly disabled through an environment variable.
  *
  * @returns True if telemetry is allowed in the environment, false otherwise.