chore: do not pass nullable nor any objects to assert.ok function

Author: galargh

v-next/core/src/internal/user-interruptions.ts

@@ -121,7 +121,7 @@ async function defaultRequestSecretInput(
       }
 
       assertHardhatInvariant(
-        rlAsAny.output,
+        rlAsAny.output !== undefined,
         "Espected readline output to be defined",
       );
 

v-next/core/test/internal/tasks/task-manager.ts

@@ -165,8 +165,8 @@ describe("TaskManagerImplementation", () => {
     assert.equal(task1.pluginId, "plugin1");
     assert.equal(task1.description, "description2");
     // Original args should have not been removed
-    assert.ok(task1.options.get("arg1"), "Should have arg1");
-    assert.ok(task1.options.get("flag1"), "Should have flag1");
+    assert.notEqual(task1.options.get("arg1"), undefined, "Should have arg1");
+    assert.notEqual(task1.options.get("flag1"), undefined, "Should have flag1");
     assert.ok(
       task1.positionalArguments.some((p) => p.name === "posArg1"),
       "Should have posArg1",
@@ -176,8 +176,8 @@ describe("TaskManagerImplementation", () => {
       "Should have varArg1",
     );
     // New args should be added by the overrides
-    assert.ok(task1.options.get("arg2"), "Should have arg2");
-    assert.ok(task1.options.get("flag2"), "Should have flag2");
+    assert.notEqual(task1.options.get("arg2"), undefined, "Should have arg2");
+    assert.notEqual(task1.options.get("flag2"), undefined, "Should have flag2");
     // Should have 2 actions
     assert.equal(task1.actions.length, 2);
     assert.equal(task1.actions[0].pluginId, "plugin1");
@@ -220,8 +220,8 @@ describe("TaskManagerImplementation", () => {
     assert.equal(task1.pluginId, "plugin1");
     assert.equal(task1.description, "description2");
     // Original args should have not been removed
-    assert.ok(task1.options.get("arg1"), "Should have arg1");
-    assert.ok(task1.options.get("flag1"), "Should have flag1");
+    assert.notEqual(task1.options.get("arg1"), undefined, "Should have arg1");
+    assert.notEqual(task1.options.get("flag1"), undefined, "Should have flag1");
     assert.ok(
       task1.positionalArguments.some((p) => p.name === "posArg1"),
       "Should have posArg1",
@@ -231,8 +231,8 @@ describe("TaskManagerImplementation", () => {
       "Should have varArg1",
     );
     // New args should be added by the overrides
-    assert.ok(task1.options.get("arg2"), "Should have arg2");
-    assert.ok(task1.options.get("flag2"), "Should have flag2");
+    assert.notEqual(task1.options.get("arg2"), undefined, "Should have arg2");
+    assert.notEqual(task1.options.get("flag2"), undefined, "Should have flag2");
     // Should have 2 actions
     assert.equal(task1.actions.length, 2);
     assert.equal(task1.actions[0].pluginId, "plugin1");
@@ -282,8 +282,8 @@ describe("TaskManagerImplementation", () => {
     assert.equal(task1.pluginId, "plugin1");
     assert.equal(task1.description, "description3");
     // Original args should have not been removed
-    assert.ok(task1.options.get("arg1"), "Should have arg1");
-    assert.ok(task1.options.get("flag1"), "Should have flag1");
+    assert.notEqual(task1.options.get("arg1"), undefined, "Should have arg1");
+    assert.notEqual(task1.options.get("flag1"), undefined, "Should have flag1");
     assert.ok(
       task1.positionalArguments.some((p) => p.name === "posArg1"),
       "Should have posArg1",
@@ -293,10 +293,10 @@ describe("TaskManagerImplementation", () => {
       "Should have varArg1",
     );
     // New args should be added by the overrides
-    assert.ok(task1.options.get("arg2"), "Should have arg2");
-    assert.ok(task1.options.get("flag2"), "Should have flag2");
-    assert.ok(task1.options.get("arg3"), "Should have arg3");
-    assert.ok(task1.options.get("flag3"), "Should have flag3");
+    assert.notEqual(task1.options.get("arg2"), undefined, "Should have arg2");
+    assert.notEqual(task1.options.get("flag2"), undefined, "Should have flag2");
+    assert.notEqual(task1.options.get("arg3"), undefined, "Should have arg3");
+    assert.notEqual(task1.options.get("flag3"), undefined, "Should have flag3");
     // Should have 3 actions
     assert.equal(task1.actions.length, 3);
     assert.equal(task1.actions[0].pluginId, "plugin1");

v-next/hardhat-utils/test/request.ts

@@ -262,7 +262,7 @@ describe("Requests util", () => {
       mockPool.intercept(baseInterceptorOptions).reply(200, {});
       const response = await getRequest(url, undefined, mockPool);
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });
@@ -277,7 +277,7 @@ describe("Requests util", () => {
         .reply(200, {});
       const response = await getRequest(url, { queryParams }, mockPool);
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });
@@ -294,7 +294,7 @@ describe("Requests util", () => {
         .reply(200, {});
       const response = await getRequest(url, { extraHeaders }, mockPool);
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });
@@ -347,7 +347,7 @@ describe("Requests util", () => {
       mockPool.intercept(baseInterceptorOptions).reply(200, {});
       const response = await postJsonRequest(url, body, undefined, mockPool);
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });
@@ -369,7 +369,7 @@ describe("Requests util", () => {
         mockPool,
       );
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });
@@ -391,7 +391,7 @@ describe("Requests util", () => {
         mockPool,
       );
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });
@@ -445,7 +445,7 @@ describe("Requests util", () => {
       mockPool.intercept(baseInterceptorOptions).reply(200, {});
       const response = await postFormRequest(url, body, undefined, mockPool);
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });
@@ -467,7 +467,7 @@ describe("Requests util", () => {
         mockPool,
       );
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });
@@ -489,7 +489,7 @@ describe("Requests util", () => {
         mockPool,
       );
 
-      assert.ok(response, "Should return a response");
+      assert.notEqual(response, undefined, "Should return a response");
       assert.equal(response.statusCode, 200);
       await response.body.json();
     });