Add dependency check for file action import failures

Author: schaable

v-next/core/src/internal/tasks/resolved-task.ts

@@ -11,10 +11,14 @@ import type {
   TaskParameter,
 } from "../../types/tasks.js";
 
-import { HardhatError } from "@nomicfoundation/hardhat-errors";
+import {
+  HardhatError,
+  assertHardhatInvariant,
+} from "@nomicfoundation/hardhat-errors";
 import { ensureError } from "@nomicfoundation/hardhat-utils/error";
 
 import { isParameterValueValid } from "../parameters.js";
+import { detectPluginNpmDependencyProblems } from "../plugins/detect-plugin-npm-dependency-problems.js";
 
 import { formatTaskId } from "./utils.js";
 
@@ -130,7 +134,7 @@ export class ResolvedTask implements Task {
       const actionFn =
         typeof currentAction === "function"
           ? currentAction
-          : await this.#resolveFileAction(currentAction, this.id);
+          : await this.#resolveFileAction(currentAction);
 
       if (currentIndex === 0) {
         /* eslint-disable-next-line @typescript-eslint/consistent-type-assertions --
@@ -237,18 +241,31 @@ export class ResolvedTask implements Task {
    */
   async #resolveFileAction(
     actionFileUrl: string,
-    taskId: string[],
   ): Promise<NewTaskActionFunction | TaskOverrideActionFunction> {
     let resolvedActionFn;
     try {
       resolvedActionFn = await import(actionFileUrl);
     } catch (error) {
       ensureError(error);
+
+      if (this.pluginId !== undefined) {
+        const plugin = this.#hre.config.plugins.find(
+          (p) => p.id === this.pluginId,
+        );
+
+        assertHardhatInvariant(
+          plugin !== undefined,
+          `Plugin with id ${this.pluginId} not found.`,
+        );
+
+        await detectPluginNpmDependencyProblems(plugin);
+      }
+
       throw new HardhatError(
         HardhatError.ERRORS.TASK_DEFINITIONS.INVALID_ACTION_URL,
         {
           action: actionFileUrl,
-          task: formatTaskId(taskId),
+          task: formatTaskId(this.id),
         },
         error,
       );
@@ -259,7 +276,7 @@ export class ResolvedTask implements Task {
         HardhatError.ERRORS.TASK_DEFINITIONS.INVALID_ACTION,
         {
           action: actionFileUrl,
-          task: formatTaskId(taskId),
+          task: formatTaskId(this.id),
         },
       );
     }

v-next/core/test/internal/tasks/task-manager.ts

@@ -1493,7 +1493,7 @@ describe("TaskManagerImplementation", () => {
         );
       });
 
-      it("should throw if an action url is provided and the module can't be resolved", async () => {
+      it("should throw if an action url is provided but the corresponding module can't be resolved", async () => {
         const hre = await createHardhatRuntimeEnvironment({
           plugins: [
             {
@@ -1520,7 +1520,40 @@ describe("TaskManagerImplementation", () => {
         );
       });
 
-      it("should throw if an action url is provided and the module doesn't have a default export", async () => {
+      /**
+       * There are multiple scenarios where detectPluginNpmDependencyProblems
+       * can throw an error. We're not trying to test all of them, just verify
+       * that the logic is being called and that the error is being thrown.
+       */
+      it("should throw if an action url is provided but the corresponding module can't be resolved due to a missing package", async () => {
+        const nonInstalledPackageActionUrl = import.meta.resolve(
+          "./fixture-projects/not-installed-package/index.js",
+        );
+
+        const hre = await createHardhatRuntimeEnvironment({
+          plugins: [
+            {
+              id: "plugin1",
+              npmPackage: "non-installed-package",
+              tasks: [
+                new NewTaskDefinitionBuilderImplementation("task1")
+                  .setAction(nonInstalledPackageActionUrl)
+                  .build(),
+              ],
+            },
+          ],
+        });
+
+        const task1 = hre.tasks.getTask("task1");
+        await assert.rejects(
+          task1.run({}),
+          new HardhatError(HardhatError.ERRORS.PLUGINS.PLUGIN_NOT_INSTALLED, {
+            pluginId: "plugin1",
+          }),
+        );
+      });
+
+      it("should throw if an action url is provided and the corresponding module doesn't have a default export", async () => {
         const actionUrl = import.meta.resolve(
           "./fixture-projects/file-actions/no-default.js",
         );
@@ -1551,7 +1584,7 @@ describe("TaskManagerImplementation", () => {
         );
       });
 
-      it("should throw if an action url is provided and the module default export is not a function", async () => {
+      it("should throw if an action url is provided and the corresponding module default export is not a function", async () => {
         const actionUrl = import.meta.resolve(
           "./fixture-projects/file-actions/no-default-fn.js",
         );