Merge branch 'main' into accept-Typed-matcher

Author: fvictorio

.github/workflows/autoassign-issues.yml

@@ -15,8 +15,8 @@ jobs:
           script: |
             // each user has a chance of (p - (previousP ?? 0)) to be assigned
             const potentialAssignees = [
-              ["fvictorio", 0.5],
-              ["schaable", 0.75],
+              ["fvictorio", 1/3],
+              ["schaable", 2/3],
               ["ChristopherDedominici", 1.0],
             ];
 

.github/workflows/release.yml

@@ -9,6 +9,9 @@ jobs:
   release:
     name: Release
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      pull-requests: write
     steps:
       - name: Checkout Repo
         uses: actions/checkout@v2

.github/workflows/test-slow-imports-rule.yml

@@ -32,7 +32,7 @@ jobs:
       - name: Install
         run: pnpm install --frozen-lockfile --prefer-offline
       - name: Add slow import
-        run: echo 'import "lodash";' >> src/internal/constants.ts
+        run: echo 'import "lodash";' >> src/internal/core/config/config-resolution.ts
       - name: Build
         run: pnpm build
       - name: Run eslint

config/eslint/constants.js

@@ -7,6 +7,7 @@ module.exports.slowImportsCommonIgnoredModules = [
   "source-map-support/register",
   "@nomicfoundation/hardhat-ethers",
   "hardhat/common",
+  "hardhat/common/bigInt",
   "hardhat/config",
   "hardhat/plugins",
   "hardhat/types",

docs/.npmrc

@@ -1 +1,2 @@
 ignore-workspace-root-check=true
+enable-pre-post-scripts=true

docs/README.md

@@ -200,7 +200,7 @@ Landing pages don't support themes.
 
 ## Creating new landings
 
-Landing pages contains special "blocks" see src/components/landingBlocks. To create a new landing page start from copying `/pages/index.tsx` and `src/content/home.ts`. You can create another page by reodering existing blocks and passing another content to them. If necessary create new landing blocks.
+Landing pages contains special "blocks" see src/components/landingBlocks. To create a new landing page start from copying `/pages/index.tsx` and `src/content/home.ts`. You can create another page by reordering existing blocks and passing another content to them. If necessary create new landing blocks.
 
 ## CI/CD
 

docs/redirects.config.js

@@ -309,6 +309,12 @@ const customRedirects = [
     destination: "/hardhat-runner/plugins/nomicfoundation-hardhat-ethers",
     permanent: false,
   },
+  {
+    source: "/release/:version",
+    destination:
+      "https://github.com/NomicFoundation/hardhat/releases/tag/hardhat%40:version",
+    permanent: false,
+  },
   ...loadErrorRedirects(),
 ];
 

docs/src/content/hardhat-runner/docs/advanced/create-task.md

@@ -63,15 +63,15 @@ npm install --save-dev @nomicfoundation/hardhat-toolbox
 :::tab{value="npm 6"}
 
 ```
-npm install --save-dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
+npm install --save-dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai@4 ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
 ```
 
 :::
 
 :::tab{value="yarn"}
 
 ```
-yarn add --dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
+yarn add --dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai@4 ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
 ```
 
 :::

docs/src/content/hardhat-runner/docs/advanced/migrating-from-hardhat-waffle.md

@@ -17,15 +17,15 @@ Follow these steps to migrate your project to Hardhat Toolbox.
    :::tab{value="npm 7+"}
 
    ```
-   npm uninstall @nomiclabs/hardhat-waffle ethereum-waffle @nomiclabs/hardhat-ethers @nomiclabs/hardhat-etherscan chai ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v5 @ethersproject/abi @ethersproject/providers
+   npm uninstall @nomiclabs/hardhat-waffle ethereum-waffle @nomiclabs/hardhat-ethers @nomiclabs/hardhat-etherscan chai@4 ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v5 @ethersproject/abi @ethersproject/providers
    ```
 
    :::
 
    :::tab{value="npm 6"}
 
    ```
-   npm uninstall @nomiclabs/hardhat-waffle ethereum-waffle @nomiclabs/hardhat-ethers @nomiclabs/hardhat-etherscan chai ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v5 @ethersproject/abi @ethersproject/providers
+   npm uninstall @nomiclabs/hardhat-waffle ethereum-waffle @nomiclabs/hardhat-ethers @nomiclabs/hardhat-etherscan chai@4 ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v5 @ethersproject/abi @ethersproject/providers
    ```
 
    :::
@@ -55,15 +55,15 @@ Follow these steps to migrate your project to Hardhat Toolbox.
    :::tab{value="npm 6"}
 
    ```
-   npm install --save-dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
+   npm install --save-dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai@4 ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
    ```
 
    :::
 
    :::tab{value="yarn"}
 
    ```
-   yarn add --dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers@1 @nomiclabs/hardhat-ethers @nomiclabs/hardhat-etherscan chai ethers@5 hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
+   yarn add --dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers@1 @nomiclabs/hardhat-ethers @nomiclabs/hardhat-etherscan chai@4 ethers@5 hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
    ```
 
    :::

docs/src/content/hardhat-runner/docs/advanced/using-viem.md

@@ -105,7 +105,7 @@ Use the `hre.viem` object to get these helpers, similar to how clients are used.
      const initialSupply = await myToken.read.getCurrentSupply();
      console.log(`Initial supply of MyToken: ${initialSupply}`);
 
-     await myToken.write.increaseSupply([500_000n]);
+     const hash = await myToken.write.increaseSupply([500_000n]);
      // increaseSupply sends a tx, so we need to wait for it to be mined
      const publicClient = await hre.viem.getPublicClient();
      await publicClient.waitForTransactionReceipt({ hash });

docs/src/content/hardhat-runner/docs/getting-started/index.md

@@ -273,7 +273,7 @@ You can run it using `npx hardhat run`:
 
 ```
 $ npx hardhat run scripts/deploy.ts
-Lock with 1 ETH deployed to: 0x5FbDB2315678afecb367f032d93F642f64180aa3
+Lock with 0.001ETH deployed to: 0x5FbDB2315678afecb367f032d93F642f64180aa3
 ```
 
 :::
@@ -282,7 +282,7 @@ Lock with 1 ETH deployed to: 0x5FbDB2315678afecb367f032d93F642f64180aa3
 
 ```
 $ npx hardhat run scripts/deploy.js
-Lock with 1 ETH deployed to: 0x5FbDB2315678afecb367f032d93F642f64180aa3
+Lock with 0.001ETH deployed to: 0x5FbDB2315678afecb367f032d93F642f64180aa3
 ```
 
 :::

docs/src/content/hardhat-runner/docs/guides/typescript.md

@@ -53,23 +53,23 @@ To be able to write your tests in TypeScript, you also need these packages:
 :::tab{value="npm 7+"}
 
 ```
-npm install --save-dev chai @types/node @types/mocha @types/chai
+npm install --save-dev chai@4 @types/node @types/mocha @types/chai@4
 ```
 
 :::
 
 :::tab{value="npm 6"}
 
 ```
-npm install --save-dev chai @types/node @types/mocha @types/chai
+npm install --save-dev chai@4 @types/node @types/mocha @types/chai@4
 ```
 
 :::
 
 :::tab{value=yarn}
 
 ```
-yarn add --dev chai @types/node @types/mocha @types/chai
+yarn add --dev chai@4 @types/node @types/mocha @types/chai@4
 ```
 
 :::

docs/src/content/hardhat-runner/docs/other-guides/waffle-testing.md

@@ -52,23 +52,23 @@ Then install [`chai`](https://www.chaijs.com/), the `@nomiclabs/hardhat-waffle`
 :::tab{value="npm 7+"}
 
 ```
-npm install --save-dev chai @nomiclabs/hardhat-waffle
+npm install --save-dev chai@4 @nomiclabs/hardhat-waffle
 ```
 
 :::
 
 :::tab{value="npm 6"}
 
 ```
-npm install --save-dev chai @nomiclabs/hardhat-waffle ethereum-waffle @nomiclabs/hardhat-ethers ethers@5
+npm install --save-dev chai@4 @nomiclabs/hardhat-waffle ethereum-waffle @nomiclabs/hardhat-ethers ethers@5
 ```
 
 :::
 
 :::tab{value="yarn"}
 
 ```
-yarn add --dev chai @nomiclabs/hardhat-waffle ethereum-waffle @nomiclabs/hardhat-ethers ethers@5
+yarn add --dev chai@4 @nomiclabs/hardhat-waffle ethereum-waffle @nomiclabs/hardhat-ethers ethers@5
 ```
 
 :::

docs/src/content/hardhat-runner/plugins/plugins.ts

@@ -748,7 +748,7 @@ const communityPlugins: IPlugin[] = [
     tags: ["transaction", "gasPrice", "retry", "helper"],
   },
   {
-    name: "hardhat-fireblocks",
+    name: "@fireblocks/hardhat-fireblocks",
     author: "Fireblocks",
     authorUrl: "https://github.com/fireblocks",
     description: "Hardhat plugin for integrating with Fireblocks",
@@ -863,6 +863,13 @@ const communityPlugins: IPlugin[] = [
       "Display different signatures that have the methods, events and errors of your contracts by console",
     tags: ["functions", "errors", "events", "tooling", "selectorss"],
   },
+  {
+    name: "@dgma/hardhat-sol-bundler",
+    author: "Dogma Labs",
+    authorUrl: "https://github.com/dgma",
+    description: "Build and deploy only changed smartcontracts",
+    tags: ["deployment", "diff deployment", "ethers.js", "proxy"],
+  },
 ];
 
 const officialPlugins: IPlugin[] = [

docs/src/content/ignition/docs/guides/creating-modules.md

@@ -122,7 +122,7 @@ m.call(myContract, "receivesEth" [], {
 
 ### Reading a value from a contract
 
-If you need to call a `view` or `pure` function in a contract to retreive a value, you can do it with `m.staticCall`:
+If you need to call a `view` or `pure` function in a contract to retrieve a value, you can do it with `m.staticCall`:
 
 ```js
 const balance = m.staticCall(token, "balanceOf", [address]);
@@ -165,7 +165,7 @@ Calling `m.send` will create a `Future` representing the sending action. The fir
 
 The second argument is the address of the account where you want to send the ETH or data to.
 
-The third and forth parameters are both optional. They represent the amount of ETH and the data to be sent.
+The third and fourth parameters are both optional. They represent the amount of ETH and the data to be sent.
 
 ### Deploying a library
 
@@ -179,7 +179,7 @@ If you need to link libraries take a look at the [Linking Libraries](#linking-li
 
 ## `Future` IDs
 
-Each `Future` that is created should have a unique ID. In most cases, Hardhat Ignition will automatically generate an ID for the every `Future` you create, based on the creation parameters.
+Each `Future` that is created should have a unique ID. In most cases, Hardhat Ignition will automatically generate an ID for every `Future` you create, based on the creation parameters.
 
 In some cases, this automatic process may lead to an ID clash with an existing `Future`. If that happens, Hardhat Ignition won't try to resolve the clash, and you will need to define an ID manually to resolve the issue. Every method of `ModuleBuilder` accepts an options object as last argument, which has an `id` field that can be used like this:
 

docs/src/content/tutorial/creating-a-new-hardhat-project.md

@@ -143,15 +143,15 @@ npm install --save-dev @nomicfoundation/hardhat-toolbox
 :::tab{value="npm 6"}
 
 ```
-npm install --save-dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
+npm install --save-dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai@4 ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
 ```
 
 :::
 
 :::tab{value=yarn}
 
 ```
-yarn add --dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
+yarn add --dev @nomicfoundation/hardhat-toolbox @nomicfoundation/hardhat-network-helpers @nomicfoundation/hardhat-chai-matchers @nomicfoundation/hardhat-ethers @nomicfoundation/hardhat-verify chai@4 ethers hardhat-gas-reporter solidity-coverage @typechain/hardhat typechain @typechain/ethers-v6
 ```
 
 :::

packages/eslint-plugin-slow-imports/lib/rules/no-top-level-external-import.js

@@ -5,7 +5,7 @@
 "use strict";
 const fs = require("node:fs");
 const { isBuiltin } = require("node:module");
-const resolve = require("eslint-module-utils/resolve").default;
+const { relative } = require("eslint-module-utils/resolve");
 const parse = require("eslint-module-utils/parse").default;
 const visit = require("eslint-module-utils/visit").default;
 const { visitModules } = require("../helpers/module-visitor");
@@ -45,6 +45,8 @@ module.exports = {
     messages: {
       ENFORCE_DYNAMIC_IMPORT:
         "This import transitively imports the slow dependency '{{dependency}}' in file '{{filename}}' at line {{line}}",
+      CANNOT_RESOLVE_MODULE:
+        "Unable to resolve the absolute module path. This is likely an error in the rule configuration or the file paths.",
     },
   },
 
@@ -55,7 +57,7 @@ module.exports = {
     function visitor(filename, originalNode, node) {
       const modulePath = node.value;
       if (ignoreModules.has(modulePath) || isBuiltin(modulePath)) {
-        return {};
+        return;
       }
 
       function detectTopLevelExternalDependency(path) {
@@ -80,10 +82,22 @@ module.exports = {
       }
 
       if (!isExternalModule(modulePath)) {
-        const absoluteModulePath = resolve(modulePath, context);
+        const absoluteModulePath = relative(
+          modulePath,
+          filename,
+          context.settings
+        );
+
+        if (!absoluteModulePath) {
+          context.report({
+            node: originalNode,
+            messageId: "CANNOT_RESOLVE_MODULE",
+          });
+          return;
+        }
 
-        if (!absoluteModulePath || traversed.has(absoluteModulePath)) {
-          return {};
+        if (traversed.has(absoluteModulePath)) {
+          return;
         }
 
         traversed.add(absoluteModulePath);

packages/hardhat-chai-matchers/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @nomicfoundation/hardhat-chai-matchers
 
+## 2.0.4
+
+### Patch Changes
+
+- ffb301f14: Improved loading performance
+
 ## 2.0.3
 
 ### Patch Changes

packages/hardhat-chai-matchers/README.md

@@ -17,13 +17,13 @@ npm install --save-dev @nomicfoundation/hardhat-chai-matchers
 If you are using an older version of npm, you'll also need to install all the packages used by the plugin.
 
 ```bash
-npm install --save-dev @nomicfoundation/hardhat-chai-matchers chai @nomicfoundation/hardhat-ethers ethers
+npm install --save-dev @nomicfoundation/hardhat-chai-matchers chai@4 @nomicfoundation/hardhat-ethers ethers
 ```
 
 That's also the case if you are using yarn:
 
 ```bash
-yarn add --dev @nomicfoundation/hardhat-chai-matchers chai @nomicfoundation/hardhat-ethers ethers
+yarn add --dev @nomicfoundation/hardhat-chai-matchers chai@4 @nomicfoundation/hardhat-ethers ethers
 ```
 
 ### Usage

packages/hardhat-chai-matchers/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nomicfoundation/hardhat-chai-matchers",
-  "version": "2.0.3",
+  "version": "2.0.4",
   "description": "Hardhat utils for testing",
   "homepage": "https://github.com/nomicfoundation/hardhat/tree/main/packages/hardhat-chai-matchers",
   "repository": "github:nomicfoundation/hardhat",

packages/hardhat-chai-matchers/src/internal/addressable.ts

@@ -1,4 +1,5 @@
-import { isAddress, isAddressable } from "ethers";
+import type EthersT from "ethers";
+
 import { tryDereference } from "./typed";
 
 export function supportAddressable(
@@ -27,6 +28,8 @@ function override(
 // so we are looking for a sync way of getting the address. If an address was recovered, it is returned as a string,
 // otherwise undefined is returned.
 function tryGetAddressSync(value: any): string | undefined {
+  const { isAddress, isAddressable } = require("ethers") as typeof EthersT;
+
   value = tryDereference(value, "address");
   if (isAddressable(value)) {
     value = (value as any).address ?? (value as any).target;

packages/hardhat-chai-matchers/src/internal/changeEtherBalances.ts

@@ -1,8 +1,7 @@
 import type EthersT from "ethers";
 import type { Addressable, BigNumberish, TransactionResponse } from "ethers";
 import type { BalanceChangeOptions } from "./misc/balance";
-
-import ordinal from "ordinal";
+import type OrdinalT from "ordinal";
 
 import { buildAssert } from "../utils";
 import { getAddressOf } from "./misc/account";
@@ -23,6 +22,7 @@ export function supportChangeEtherBalances(
       options?: BalanceChangeOptions
     ) {
       const { toBigInt } = require("ethers") as typeof EthersT;
+      const ordinal = require("ordinal") as typeof OrdinalT;
       // capture negated flag before async code executes; see buildAssert's jsdoc
       const negated = this.__flags.negate;