Add comment about bug in assert and assert.ok

schaable · schaable · commit cb4a84165645 · 2024-06-11T16:55:24.000-03:00
diff --git a/config-v-next/eslint.cjs b/config-v-next/eslint.cjs
@@ -227,6 +227,8 @@ function createConfig(configFilePath, packageEntryPoints = []) {
           message:
             "Use non-strict methods when importing from 'node:assert/strict'",
         },
+        // We forbid using assert.ok and assert directly without a message
+        // as this may cause a bug. See: https://github.com/nodejs/node/issues/52962
         {
           selector: "CallExpression[callee.name='assert'][arguments.length<2]",
           message:

Original file line number	Diff line number	Diff line change
`@@ -227,6 +227,8 @@ function createConfig(configFilePath, packageEntryPoints = []) {`
`227`	`227`	`message:`
`228`	`228`	`"Use non-strict methods when importing from 'node:assert/strict'",`
`229`	`229`	`},`
	`230`	`+ // We forbid using assert.ok and assert directly without a message`
	`231`	`+ // as this may cause a bug. See: https://github.com/nodejs/node/issues/52962`
`230`	`232`	`{`
`231`	`233`	`selector: "CallExpression[callee.name='assert'][arguments.length<2]",`
`232`	`234`	`message:`