chore: move cache value type declaration to the constructor

Author: galargh

v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/build-system.ts

@@ -46,7 +46,7 @@ import {
   getContractArtifact,
   getDuplicatedContractNamesDeclarationFile,
 } from "./artifacts.js";
-import { Cache } from "./cache.js";
+import { ObjectCache } from "./cache.js";
 import { CompilationJobImplementation } from "./compilation-job.js";
 import { downloadConfiguredCompilers, getCompiler } from "./compiler/index.js";
 import { buildDependencyGraph } from "./dependency-graph-building.js";
@@ -76,13 +76,13 @@ export interface SolidityBuildSystemOptions {
 
 export class SolidityBuildSystemImplementation implements SolidityBuildSystem {
   readonly #options: SolidityBuildSystemOptions;
-  readonly #compilerOutputCache: Cache;
+  readonly #compilerOutputCache: ObjectCache<CompilerOutput>;
   readonly #defaultConcurrency = Math.max(os.cpus().length - 1, 1);
   #downloadedCompilers = false;
 
   constructor(options: SolidityBuildSystemOptions) {
     this.#options = options;
-    this.#compilerOutputCache = new Cache(
+    this.#compilerOutputCache = new ObjectCache<CompilerOutput>(
       options.cachePath,
       "hardhat.core.solidity.build-system.compiler-output",
       "v1",
@@ -141,7 +141,7 @@ export class SolidityBuildSystemImplementation implements SolidityBuildSystem {
 
         if (runCompilationJobOptions?.force !== true) {
           const cachedCompilerOutput =
-            await this.#compilerOutputCache.getJson<CompilerOutput>(buildId);
+            await this.#compilerOutputCache.get(buildId);
           if (cachedCompilerOutput !== undefined) {
             log(`Using cached compiler output for build ${buildId}`);
             return {
@@ -180,7 +180,7 @@ export class SolidityBuildSystemImplementation implements SolidityBuildSystem {
     // will only care about the result of these operations in subsequent runs
     void Promise.all(
       uncachedSuccessfulResults.map(async (result) => {
-        return this.#compilerOutputCache.setJson(
+        return this.#compilerOutputCache.set(
           result.compilationJob.getBuildId(),
           result.compilerOutput,
         );

v-next/hardhat/src/internal/builtin-plugins/solidity/build-system/cache.ts

@@ -10,7 +10,7 @@ import {
   writeJsonFile,
 } from "@ignored/hardhat-vnext-utils/fs";
 
-export class Cache {
+export class ObjectCache<T> {
   readonly #path: string;
   readonly #maxAgeMs: number = 0;
   readonly #maxSize: number = 0;
@@ -19,12 +19,12 @@ export class Cache {
     this.#path = path.join(basePath, namespace, version);
   }
 
-  public async setJson<T>(key: string, value: T): Promise<void> {
+  public async set(key: string, value: T): Promise<void> {
     const filePath = path.join(this.#path, key);
     await writeJsonFile(filePath, value);
   }
 
-  public async getJson<T>(key: string): Promise<T | undefined> {
+  public async get(key: string): Promise<T | undefined> {
     const filePath = path.join(this.#path, key);
     return (await exists(filePath)) ? readJsonFile<T>(filePath) : undefined;
   }