chore: apply suggestions from code review

galargh · web-flow · commit d144d839ea19 · 2024-08-07T16:40:58.000+02:00
diff --git a/.changeset/shaggy-bags-work.md b/.changeset/shaggy-bags-work.md
@@ -2,4 +2,4 @@
 "hardhat": patch
 ---
 
-Do not send `http_setLedgerOutputEnabled` messages if they reacht the HTTP Provider to prevent unwanted warnings in the local hardhat node logs
+Do not send `http_setLedgerOutputEnabled` messages beyond the HTTP Provider to prevent unwanted warnings in the logs of the local hardhat node
diff --git a/packages/hardhat-core/src/internal/core/providers/http.ts b/packages/hardhat-core/src/internal/core/providers/http.ts
@@ -86,6 +86,8 @@ export class HttpProvider extends EventEmitter implements EIP1193Provider {
   }
 
   public async request(args: RequestArguments): Promise<unknown> {
+    // This is a temporary fix to an issue with noisy warnings in the logs
+    // of a local node (#5406). This will be fixed in the next major release.
     if (args.method === "hardhat_setLedgerOutputEnabled") {
       const error = new ProviderError(
         "hardhat_setLedgerOutputEnabled - Method not supported",

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,8 @@ export class HttpProvider extends EventEmitter implements EIP1193Provider {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`public async request(args: RequestArguments): Promise<unknown> {`
	`89`	`+ // This is a temporary fix to an issue with noisy warnings in the logs`
	`90`	`+ // of a local node (#5406). This will be fixed in the next major release.`
`89`	`91`	`if (args.method === "hardhat_setLedgerOutputEnabled") {`
`90`	`92`	`const error = new ProviderError(`
`91`	`93`	`"hardhat_setLedgerOutputEnabled - Method not supported",`