build: remove support for i686 & arm windows builds (#5108)

Author: Wodann

.changeset/silver-sheep-exist.md

@@ -0,0 +1,5 @@
+---
+"@nomicfoundation/edr": patch
+---
+
+Removed i686 & ARM builds of EDR

.github/workflows/edr-npm-release.yml

@@ -37,11 +37,6 @@ jobs:
           - host: windows-latest
             build: pnpm build
             target: x86_64-pc-windows-msvc
-          - host: windows-latest
-            build: |
-              pnpm build --target i686-pc-windows-msvc
-              pnpm testNoBuild
-            target: i686-pc-windows-msvc
           - host: ubuntu-latest
             target: x86_64-unknown-linux-gnu
             docker: ghcr.io/napi-rs/napi-rs/nodejs-rust@sha256:4b2638c0987845c4ab3488574a215a2a866b99fb28588788786f2b8cbcb40e71
@@ -85,9 +80,6 @@ jobs:
               rustup target add aarch64-unknown-linux-musl &&
               pnpm run build --target aarch64-unknown-linux-musl &&
               /aarch64-linux-musl-cross/bin/aarch64-linux-musl-strip *.node
-          - host: windows-latest
-            target: aarch64-pc-windows-msvc
-            build: pnpm build --target aarch64-pc-windows-msvc
     name: stable - ${{ matrix.settings.target }} - node@18
     runs-on: ${{ matrix.settings.host }}
     defaults:
@@ -131,20 +123,8 @@ jobs:
         if: ${{ matrix.settings.target == 'armv7-unknown-linux-gnueabihf' }}
         with:
           version: 0.10.1
-      - name: Setup node x86
-        if: matrix.settings.target == 'i686-pc-windows-msvc'
-        run: pnpm config set supportedArchitectures.cpu "ia32"
-        shell: bash
       - name: Install dependencies
         run: pnpm install --frozen-lockfile --prefer-offline
-      - name: Setup node x86
-        uses: actions/setup-node@v3
-        if: matrix.settings.target == 'i686-pc-windows-msvc'
-        with:
-          node-version: 18
-          check-latest: true
-          cache: pnpm
-          architecture: x86
       - name: Build in docker
         uses: addnab/docker-run-action@v3
         if: ${{ matrix.settings.docker }}

book/src/02_development/04_update_napi_targets.md

@@ -0,0 +1,21 @@
+First, install `@napi-rs/cli`:
+
+```bash
+npm -g i @napi-rs/cli
+```
+
+Then follow the steps in [this document](https://napi.rs/docs/introduction/simple-package) to generate a package with the desired supported target triples.
+
+You will be prompted for several inputs.
+Use the package name `@nomicfoundation/edr` and select the desired target triples.
+
+Once done, replace the `napi.triples.additional` entries in `crates/edr_napi/package.json` with the values in the generated `package.json` and replace `crates/edr_napi/npm` with the generated `npm` folder.
+
+Ensure that the `version` field of all `npm/*/package.json` files is set to the latest release and `engines.node` to the minimum supported version.
+
+Finally, to update the `index.js`, run:
+
+```bash
+cd crates/edr_napi &&
+pnpm build
+```

book/src/SUMMARY.md

@@ -11,6 +11,7 @@
   - [Tools](02_development/01_tools.md)
   - [Verdaccio](02_development/02_verdaccio.md)
   - [Local release](02_development/03_local_release.md)
+  - [Update N-API targets](02_development/04_update_napi_targets.md)
 
 - [Release](./03_release.md)
 

crates/edr_napi/index.js

@@ -224,17 +224,32 @@ switch (platform) {
         }
         break
       case 'arm':
-        localFileExisted = existsSync(
-          join(__dirname, 'edr.linux-arm-gnueabihf.node')
-        )
-        try {
-          if (localFileExisted) {
-            nativeBinding = require('./edr.linux-arm-gnueabihf.node')
-          } else {
-            nativeBinding = require('@nomicfoundation/edr-linux-arm-gnueabihf')
+        if (isMusl()) {
+          localFileExisted = existsSync(
+            join(__dirname, 'edr.linux-arm-musleabihf.node')
+          )
+          try {
+            if (localFileExisted) {
+              nativeBinding = require('./edr.linux-arm-musleabihf.node')
+            } else {
+              nativeBinding = require('@nomicfoundation/edr-linux-arm-musleabihf')
+            }
+          } catch (e) {
+            loadError = e
+          }
+        } else {
+          localFileExisted = existsSync(
+            join(__dirname, 'edr.linux-arm-gnueabihf.node')
+          )
+          try {
+            if (localFileExisted) {
+              nativeBinding = require('./edr.linux-arm-gnueabihf.node')
+            } else {
+              nativeBinding = require('@nomicfoundation/edr-linux-arm-gnueabihf')
+            }
+          } catch (e) {
+            loadError = e
           }
-        } catch (e) {
-          loadError = e
         }
         break
       case 'riscv64':

crates/edr_napi/npm/win32-arm64-msvc/README.md

@@ -19,17 +19,15 @@
     "triples": {
       "additional": [
         "aarch64-apple-darwin",
-        "aarch64-pc-windows-msvc",
         "aarch64-unknown-linux-gnu",
         "aarch64-unknown-linux-musl",
-        "x86_64-unknown-linux-musl",
-        "i686-pc-windows-msvc"
+        "x86_64-unknown-linux-musl"
       ]
     }
   },
   "license": "MIT",
   "devDependencies": {
-    "@napi-rs/cli": "^2.16.3",
+    "@napi-rs/cli": "^2.18.1",
     "@types/chai": "^4.2.0",
     "@types/chai-as-promised": "^7.1.8",
     "@types/mocha": ">=9.1.0",