Skip to content

Commit ef7ffef

Browse files
schaableschaable
committed
Replaced all usages of BigInt() with BigInt literals (n prefix)
1 parent 0b48282 commit ef7ffef

File tree

5 files changed

+63
-81
lines changed

5 files changed

+63
-81
lines changed

‎packages/hardhat-chai-matchers/test/bigNumber.ts

Lines changed: 36 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -832,13 +832,13 @@ describe("BigNumber matchers", function () {
832832

833833
describe(`when using .to.${operator}`, function () {
834834
it("with an unsafe int as the first param", function () {
835-
expect(() => expect(unsafeInt).to[operator](BigInt(1))).to.throw(
835+
expect(() => expect(unsafeInt).to[operator](1n)).to.throw(
836836
HardhatError,
837837
msg
838838
);
839839
});
840840
it("with an unsafe int as the second param", function () {
841-
expect(() => expect(BigInt(1)).to[operator](unsafeInt)).to.throw(
841+
expect(() => expect(1n).to[operator](unsafeInt)).to.throw(
842842
HardhatError,
843843
msg
844844
);
@@ -847,14 +847,16 @@ describe("BigNumber matchers", function () {
847847

848848
describe(`when using .not.to.${operator}`, function () {
849849
it("with an unsafe int as the first param", function () {
850-
expect(() =>
851-
expect(unsafeInt).not.to[operator](BigInt(1))
852-
).to.throw(HardhatError, msg);
850+
expect(() => expect(unsafeInt).not.to[operator](1n)).to.throw(
851+
HardhatError,
852+
msg
853+
);
853854
});
854855
it("with an unsafe int as the second param", function () {
855-
expect(() =>
856-
expect(BigInt(1)).not.to[operator](unsafeInt)
857-
).to.throw(HardhatError, msg);
856+
expect(() => expect(1n).not.to[operator](unsafeInt)).to.throw(
857+
HardhatError,
858+
msg
859+
);
858860
});
859861
});
860862
});
@@ -1153,37 +1155,43 @@ describe("BigNumber matchers", function () {
11531155

11541156
describe(`when using .to.${operator}`, function () {
11551157
it("with an unsafe int as the first param", function () {
1156-
expect(() =>
1157-
expect(unsafeInt).to[operator](BigInt(1), BigInt(1))
1158-
).to.throw(HardhatError, msg);
1158+
expect(() => expect(unsafeInt).to[operator](1n, 1n)).to.throw(
1159+
HardhatError,
1160+
msg
1161+
);
11591162
});
11601163
it("with an unsafe int as the second param", function () {
1161-
expect(() =>
1162-
expect(BigInt(1)).to[operator](unsafeInt, BigInt(1))
1163-
).to.throw(HardhatError, msg);
1164+
expect(() => expect(1n).to[operator](unsafeInt, 1n)).to.throw(
1165+
HardhatError,
1166+
msg
1167+
);
11641168
});
11651169
it("with an unsafe int as the third param", function () {
1166-
expect(() =>
1167-
expect(BigInt(1)).to[operator](BigInt(1), unsafeInt)
1168-
).to.throw(HardhatError, msg);
1170+
expect(() => expect(1n).to[operator](1n, unsafeInt)).to.throw(
1171+
HardhatError,
1172+
msg
1173+
);
11691174
});
11701175
});
11711176

11721177
describe(`when using not.to.${operator}`, function () {
11731178
it("with an unsafe int as the first param", function () {
1174-
expect(() =>
1175-
expect(unsafeInt).not.to[operator](BigInt(1), BigInt(1))
1176-
).to.throw(HardhatError, msg);
1179+
expect(() => expect(unsafeInt).not.to[operator](1n, 1n)).to.throw(
1180+
HardhatError,
1181+
msg
1182+
);
11771183
});
11781184
it("with an unsafe int as the second param", function () {
1179-
expect(() =>
1180-
expect(BigInt(1)).not.to[operator](unsafeInt, BigInt(1))
1181-
).to.throw(HardhatError, msg);
1185+
expect(() => expect(1n).not.to[operator](unsafeInt, 1n)).to.throw(
1186+
HardhatError,
1187+
msg
1188+
);
11821189
});
11831190
it("with an unsafe int as the third param", function () {
1184-
expect(() =>
1185-
expect(BigInt(1)).not.to[operator](BigInt(1), unsafeInt)
1186-
).to.throw(HardhatError, msg);
1191+
expect(() => expect(1n).not.to[operator](1n, unsafeInt)).to.throw(
1192+
HardhatError,
1193+
msg
1194+
);
11871195
});
11881196
});
11891197
});
@@ -1198,7 +1206,7 @@ describe("BigNumber matchers", function () {
11981206
);
11991207

12001208
// number and bigint
1201-
expect(() => expect(1).to.equal(BigInt(2), "custom message")).to.throw(
1209+
expect(() => expect(1).to.equal(2n, "custom message")).to.throw(
12021210
AssertionError,
12031211
"custom message"
12041212
);
@@ -1210,7 +1218,7 @@ describe("BigNumber matchers", function () {
12101218
);
12111219

12121220
// number and bigint
1213-
expect(() => expect([1]).to.equal([BigInt(2)], "custom message")).to.throw(
1221+
expect(() => expect([1]).to.equal([2n], "custom message")).to.throw(
12141222
AssertionError,
12151223
"custom message"
12161224
);

‎packages/hardhat-chai-matchers/test/changeEtherBalance.ts

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ describe("INTEGRATION: changeEtherBalance matcher", function () {
104104
to: receiver.address,
105105
value: 200,
106106
})
107-
).to.changeEtherBalance(sender, BigInt("-200"));
107+
).to.changeEtherBalance(sender, -200n);
108108
});
109109

110110
it("Should pass when given a predicate", async () => {
@@ -113,10 +113,7 @@ describe("INTEGRATION: changeEtherBalance matcher", function () {
113113
to: receiver.address,
114114
value: 200,
115115
})
116-
).to.changeEtherBalance(
117-
sender,
118-
(diff: bigint) => diff === BigInt("-200")
119-
);
116+
).to.changeEtherBalance(sender, (diff: bigint) => diff === -200n);
120117
});
121118

122119
it("Should pass when expected balance change is passed as int and is equal to an actual", async () => {
@@ -149,7 +146,7 @@ describe("INTEGRATION: changeEtherBalance matcher", function () {
149146
})
150147
).to.changeEtherBalance(
151148
sender,
152-
(diff: bigint) => diff === BigInt(-(txGasFees + 200)),
149+
(diff: bigint) => diff === -(BigInt(txGasFees) + 200n),
153150
{
154151
includeFee: true,
155152
}
@@ -184,7 +181,7 @@ describe("INTEGRATION: changeEtherBalance matcher", function () {
184181
})
185182
).to.not.changeEtherBalance(
186183
receiver,
187-
(diff: bigint) => diff === BigInt(300)
184+
(diff: bigint) => diff === 300n
188185
);
189186
});
190187

@@ -226,10 +223,7 @@ describe("INTEGRATION: changeEtherBalance matcher", function () {
226223
to: receiver.address,
227224
value: 200,
228225
})
229-
).to.changeEtherBalance(
230-
sender,
231-
(diff: bigint) => diff === BigInt(-500)
232-
)
226+
).to.changeEtherBalance(sender, (diff: bigint) => diff === -500n)
233227
).to.be.eventually.rejectedWith(
234228
AssertionError,
235229
`Expected the ether balance change of "${sender.address}" to satisfy the predicate, but it didn't (balance change: -200 wei)`
@@ -259,7 +253,7 @@ describe("INTEGRATION: changeEtherBalance matcher", function () {
259253
})
260254
).to.not.changeEtherBalance(
261255
sender,
262-
(diff: bigint) => diff === BigInt(-200)
256+
(diff: bigint) => diff === -200n
263257
)
264258
).to.be.eventually.rejectedWith(
265259
AssertionError,

‎packages/hardhat-chai-matchers/test/changeEtherBalances.ts

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,7 @@ describe("INTEGRATION: changeEtherBalances matcher", function () {
105105
gasPrice: 1,
106106
value: 200,
107107
})
108-
).to.changeEtherBalances(
109-
[sender, receiver],
110-
[BigInt("-200"), BigInt(200)]
111-
);
108+
).to.changeEtherBalances([sender, receiver], [-200n, 200n]);
112109
});
113110

114111
it("Should pass when given a predicate", async () => {
@@ -120,11 +117,8 @@ describe("INTEGRATION: changeEtherBalances matcher", function () {
120117
})
121118
).to.changeEtherBalances(
122119
[sender, receiver],
123-
([senderDiff, receiverDiff]: bigint[]) => {
124-
return (
125-
senderDiff === BigInt(-200) && receiverDiff === BigInt(200)
126-
);
127-
}
120+
([senderDiff, receiverDiff]: bigint[]) =>
121+
senderDiff === -200n && receiverDiff === 200n
128122
);
129123
});
130124

@@ -138,11 +132,8 @@ describe("INTEGRATION: changeEtherBalances matcher", function () {
138132
})
139133
).to.changeEtherBalances(
140134
[sender, receiver],
141-
([senderDiff, receiverDiff]: bigint[]) => {
142-
return (
143-
senderDiff === BigInt(-201) && receiverDiff === BigInt(200)
144-
);
145-
}
135+
([senderDiff, receiverDiff]: bigint[]) =>
136+
senderDiff === -201n && receiverDiff === 200n
146137
)
147138
).to.be.eventually.rejectedWith(
148139
AssertionError,
@@ -160,11 +151,8 @@ describe("INTEGRATION: changeEtherBalances matcher", function () {
160151
})
161152
).to.not.changeEtherBalances(
162153
[sender, receiver],
163-
([senderDiff, receiverDiff]: bigint[]) => {
164-
return (
165-
senderDiff === BigInt(-200) && receiverDiff === BigInt(200)
166-
);
167-
}
154+
([senderDiff, receiverDiff]: bigint[]) =>
155+
senderDiff === -200n && receiverDiff === 200n
168156
)
169157
).to.be.eventually.rejectedWith(
170158
AssertionError,

‎packages/hardhat-chai-matchers/test/changeTokenBalance.ts

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
130130
).to.not.changeTokenBalance(
131131
mockToken,
132132
sender,
133-
(diff: bigint) => diff > BigInt(0)
133+
(diff: bigint) => diff > 0n
134134
);
135135

136136
await expect(() =>
@@ -165,7 +165,7 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
165165
).to.changeTokenBalance(
166166
mockToken,
167167
sender,
168-
(diff: bigint) => diff > BigInt(0)
168+
(diff: bigint) => diff > 0n
169169
)
170170
).to.be.rejectedWith(
171171
AssertionError,
@@ -191,7 +191,7 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
191191
).to.not.changeTokenBalance(
192192
mockToken,
193193
sender,
194-
(diff: bigint) => diff < BigInt(1)
194+
(diff: bigint) => diff < 1n
195195
)
196196
).to.be.rejectedWith(
197197
AssertionError,
@@ -240,9 +240,8 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
240240
).to.changeTokenBalances(
241241
mockToken,
242242
[sender, receiver],
243-
([senderDiff, receiverDiff]: bigint[]) => {
244-
return senderDiff === BigInt(-75) && receiverDiff === BigInt(75);
245-
}
243+
([senderDiff, receiverDiff]: bigint[]) =>
244+
senderDiff === -75n && receiverDiff === 75n
246245
);
247246
});
248247

@@ -253,9 +252,8 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
253252
).to.changeTokenBalances(
254253
mockToken,
255254
[sender, receiver],
256-
([senderDiff, receiverDiff]: bigint[]) => {
257-
return senderDiff === BigInt(-74) && receiverDiff === BigInt(75);
258-
}
255+
([senderDiff, receiverDiff]: bigint[]) =>
256+
senderDiff === -74n && receiverDiff === 75n
259257
)
260258
).to.be.eventually.rejectedWith(
261259
AssertionError,
@@ -270,9 +268,8 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
270268
).to.not.changeTokenBalances(
271269
mockToken,
272270
[sender, receiver],
273-
([senderDiff, receiverDiff]: bigint[]) => {
274-
return senderDiff === BigInt(-75) && receiverDiff === BigInt(75);
275-
}
271+
([senderDiff, receiverDiff]: bigint[]) =>
272+
senderDiff === -75n && receiverDiff === 75n
276273
)
277274
).to.be.eventually.rejectedWith(
278275
AssertionError,
@@ -394,7 +391,7 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
394391
).to.changeTokenBalance(
395392
mockToken,
396393
receiver,
397-
(diff: bigint) => diff === BigInt(500)
394+
(diff: bigint) => diff === 500n
398395
)
399396
).to.be.rejectedWith(
400397
AssertionError,
@@ -420,7 +417,7 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
420417
).to.not.changeTokenBalance(
421418
mockToken,
422419
receiver,
423-
(diff: bigint) => diff === BigInt(50)
420+
(diff: bigint) => diff === 50n
424421
)
425422
).to.be.rejectedWith(
426423
AssertionError,
@@ -710,15 +707,11 @@ describe("INTEGRATION: changeTokenBalance and changeTokenBalances matchers", fun
710707
it("native bigints are accepted", async function () {
711708
await expect(
712709
mockToken.transfer(receiver.address, 50)
713-
).to.changeTokenBalance(mockToken, sender, BigInt(-50));
710+
).to.changeTokenBalance(mockToken, sender, -50n);
714711

715712
await expect(
716713
mockToken.transfer(receiver.address, 50)
717-
).to.changeTokenBalances(
718-
mockToken,
719-
[sender, receiver],
720-
[BigInt(-50), BigInt(50)]
721-
);
714+
).to.changeTokenBalances(mockToken, [sender, receiver], [-50n, 50n]);
722715
});
723716
});
724717

‎packages/hardhat-chai-matchers/test/reverted/revertedWithPanic.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,7 @@ describe("INTEGRATION: Reverted with panic", function () {
246246
await runSuccessfulAsserts({
247247
matchers,
248248
method: "succeeds",
249-
successfulAssert: (x) =>
250-
expect(x).not.to.be.revertedWithPanic(BigInt(1)),
249+
successfulAssert: (x) => expect(x).not.to.be.revertedWithPanic(1n),
251250
});
252251
});
253252

0 commit comments

Comments
 (0)