Task parameters are treated as unrecognized global parameters (#5373)

Author: ChristopherDedominici

v-next/hardhat/src/internal/cli/main.ts

@@ -224,6 +224,7 @@ export async function parseGlobalArguments(
     usedCliArguments,
     parameters,
     globalArguments,
+    true,
   );
 
   return globalArguments;
@@ -357,6 +358,7 @@ function parseDoubleDashArgs(
   usedCliArguments: boolean[],
   parametersMap: Map<string, NamedTaskParameter | GlobalParameter>,
   argumentsMap: TaskArguments,
+  ignoreUnknownParameter = false,
 ) {
   for (let i = 0; i < cliArguments.length; i++) {
     if (usedCliArguments[i]) {
@@ -379,6 +381,11 @@ function parseDoubleDashArgs(
     const paramInfo = parametersMap.get(paramName);
 
     if (paramInfo === undefined) {
+      if (ignoreUnknownParameter === true) {
+        continue;
+      }
+
+      // Only throw an error when the parameter is not a global parameter, because it might be a parameter related to a task
       throw new HardhatError(
         HardhatError.ERRORS.ARGUMENTS.UNRECOGNIZED_NAMED_PARAM,
         {

v-next/hardhat/test/internal/cli/main.ts

@@ -214,6 +214,22 @@ describe("main", function () {
         flag: true,
       });
     });
+
+    it("should not fail when a global parameter is not recognized (it might be a task parameter)", async function () {
+      const command = "npx hardhat task --taskFlag <value>";
+
+      const cliArguments = command.split(" ").slice(2);
+      const usedCliArguments = new Array(cliArguments.length).fill(false);
+
+      const globalArguments = await parseGlobalArguments(
+        globalParamsIndex,
+        cliArguments,
+        usedCliArguments,
+      );
+
+      assert.deepEqual(usedCliArguments, [false, false, false]);
+      assert.deepEqual(globalArguments, {});
+    });
   });
 
   describe("parseTaskAndArguments", function () {