Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v-next] Rename globalArgument and namedParameters #5376

Closed
alcuadrado opened this issue Jun 11, 2024 · 0 comments · Fixed by #5417
Closed

[v-next] Rename globalArgument and namedParameters #5376

alcuadrado opened this issue Jun 11, 2024 · 0 comments · Fixed by #5417
Assignees
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone

Comments

@alcuadrado
Copy link
Member

When discussing the help messages with @zoeyTM, we found that the wording was a bit confusing, so we decided to rename "global arguments" to "global options", and "named parameters" to "task options".

Basically, --option vs positional parameter, depending on whether the argument is passed with -- or positionally.

We should rename these concepts in the codebase to be consistent.

@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Jun 11, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jun 11, 2024
@kanej kanej moved this from Backlog to To-do in Hardhat Jun 12, 2024
@kanej kanej added this to the vnext milestone Jun 12, 2024
@zoeyTM zoeyTM self-assigned this Jun 19, 2024
@zoeyTM zoeyTM moved this from To-do to In Progress in Hardhat Jun 19, 2024
@zoeyTM zoeyTM linked a pull request Jun 20, 2024 that will close this issue
@zoeyTM zoeyTM moved this from In Progress to In Review in Hardhat Jun 20, 2024
@zoeyTM zoeyTM moved this from In Review to Done in Hardhat Jun 24, 2024
@kanej kanej closed this as completed Jun 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants