Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc version outdated #5427

Closed
aaronzshey opened this issue Jun 25, 2024 · 0 comments · Fixed by #5428
Closed

solc version outdated #5427

aaronzshey opened this issue Jun 25, 2024 · 0 comments · Fixed by #5428
Assignees

Comments

@aaronzshey
Copy link
Contributor

The Problem

The version of solc hardhat uses is 0.7.3, released 4 years ago.

Why should we fix it though?

When I install hardhat, I get the following warns:

npm WARN deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported

Here's the output of pnpm why rimraf

devDependencies:
hardhat link:packages/hardhat-core
└─┬ solc 0.7.3
  └─┬ fs-extra 0.30.0
    └── rimraf 2.7.1

and pnpm why glob

devDependencies:
hardhat link:packages/hardhat-core
├── glob 7.2.0
├─┬ mocha 10.4.0
│ └── glob 8.1.0
└─┬ solc 0.7.3
  └─┬ fs-extra 0.30.0
    └─┬ rimraf 2.7.1
      └── glob 7.2.0

By upgrading solc from 0.7.3 to 0.8.26, we can eliminate outdated versions of glob and rimraf from the dependencies. solc 0.8.26 has 7 dependencies, while solc 0.7.3 has 9 dependencies (including the two aforementioned outdated ones)

Steps to Reproduce the Problem

  1. create a new node project
  2. install hardhat (npm i hardhat)
  3. read following warnings

Specifications

  • Hardhat Version: 2.22.5
  • pnpm Version: 9.4.0
  • node version: 21.2.0
  • Platform: macOS 12.7.2

More Info

I have a huge pet peeve for npm warns! I'd be super happy to be assigned to this issue and work on upgrading the solc version. I'll link my fork in a second.

TL;DR:

solc is outdated; upgrading it will reduce warn messages on npm install and also hopefully reduce dependencies. quality of life pretty much.

@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jun 25, 2024
alcuadrado added a commit that referenced this issue Jun 25, 2024
changed solc version to 0.8.26 - resolves #5427
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat Jun 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants