Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tasks for v-next #5536

Closed
2 of 5 tasks
schaable opened this issue Jul 19, 2024 · 0 comments
Closed
2 of 5 tasks

Refactoring tasks for v-next #5536

schaable opened this issue Jul 19, 2024 · 0 comments
Assignees
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Milestone

Comments

@schaable
Copy link
Member

schaable commented Jul 19, 2024

Here's a list of refactoring tasks we can work on to improve consistency and clarity:

  • v-next/core/src/global-dir.ts: Path is too high in the hierarchy. It should be moved to v-next/core/src/internal or v-next/core/src/internal/utils. Moved to hardhat-utils/global-dir.
  • v-next/hardhat/src/internal/helpers/config-loading.ts should be moved to v-next/hardhat/src/internal or v-next/hardhat/src/internal/utils.
  • v-next/hardhat/src/internal/constants.ts and v-next/hardhat/src/internal/cli/init/constants.ts should be unified.
  • v-next/hardhat/src/internal/cli/helpers/getGlobalHelpString.ts and v-next/hardhat/src/internal/cli/helpers/getHelpString.ts should be renamed to snake-case.
  • The path v-next/hardhat/src/internal/cli/helpers contains files related to the help CLI option, but the name could be more explicit. Renaming it to help would be consistent with the init folder and avoid confusion with utils folders.
@schaable schaable added the v-next A Hardhat v3 development task label Jul 19, 2024
@schaable schaable added this to Hardhat Jul 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Jul 19, 2024
@schaable schaable moved this from Backlog to To-do in Hardhat Jul 19, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jul 19, 2024
@kanej kanej added this to the Public Alpha milestone Dec 5, 2024
@antico5 antico5 moved this from To-do to In Progress in Hardhat Dec 9, 2024
@kanej kanej moved this from In Progress to In Review in Hardhat Dec 9, 2024
@kanej kanej closed this as completed Dec 13, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Dec 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Archived in project
Development

No branches or pull requests

4 participants