Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardhat-foundry should inherit compiler settings #5561

Open
sebastiantf opened this issue Aug 1, 2024 · 1 comment
Open

hardhat-foundry should inherit compiler settings #5561

sebastiantf opened this issue Aug 1, 2024 · 1 comment
Assignees
Labels
status:ready This issue is ready to be worked on

Comments

@sebastiantf
Copy link

sebastiantf commented Aug 1, 2024

Describe the feature

Not sure if something's missing, but even after using hardhat-foundry, if I remove solidity compiler config from hardhat config, it is not automatically picked up from foundry config. I get the warning that the config is not there and defaults to v0.7.3

Ideally solidity compiler settings including version and optimizer runs should be picked up from foundry

Search terms

hardhat-foundry compiler setting optimizer runs foundry hardhat config

@fvictorio fvictorio added this to Hardhat Aug 1, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Aug 1, 2024
@sebastiantf sebastiantf changed the title hardhat-foundry should take compiler settings hardhat-foundry should inherit compiler settings Aug 1, 2024
@kanej kanej added status:ready This issue is ready to be worked on and removed status:triaging labels Aug 5, 2024
@kanej
Copy link
Member

kanej commented Aug 5, 2024

Being able to rely just on the foundry.toml rather than replicating the compiler settings in both foundry.toml and hardhat.config.{js,ts} makes sense.
I think it would work like a fallback, if the Solidity configuration value is missing, attempt to resolve the correct settings from the foundry.toml.
We need to take a look at the options foundry allows for Solidity, and establish that for every configuration, we can transform that into an equivalent in Hardhat when the foundry.toml is acting as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: Backlog
Development

No branches or pull requests

2 participants