Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint and typescript-eslint #5568

Open
alcuadrado opened this issue Aug 2, 2024 · 0 comments
Open

Upgrade eslint and typescript-eslint #5568

alcuadrado opened this issue Aug 2, 2024 · 0 comments
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task

Comments

@alcuadrado
Copy link
Member

A new version of eslint (9.0.0) has been released some time ago, which we couldn't migrate into because typescript-eslint was incompatible.

Now, typescript-eslint 8.0.0 has been released that supports it, so we should migrate while v-next is small/simple.

The main advantage of migrating is that typescript-eslint now works better with node:test, allowing us to use no-floating-promise in our tests, without having tons of false-positives because of describe and it returning promises.

The only real blockers that may be present are the third-party plugins that we use:

  • eslint-config-prettier
  • eslint-import-resolver-typescript
  • eslint-plugin-import
  • eslint-plugin-no-only-tests
@alcuadrado alcuadrado added the v-next A Hardhat v3 development task label Aug 2, 2024
@fvictorio fvictorio added this to Hardhat Aug 2, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 2, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Aug 2, 2024
@kanej kanej moved this from Backlog to To-do in Hardhat Aug 2, 2024
@kanej kanej added this to the vnext milestone Dec 5, 2024
@kanej kanej modified the milestones: vnext, Feature Rollout Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Status: To-do
Development

No branches or pull requests

2 participants