Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo cannot patch ethers du to hardhat-toolbox using obselete version of hardhat-gas-reporter #5795

Closed
kopax opened this issue Oct 1, 2024 · 2 comments
Assignees

Comments

@kopax
Copy link

kopax commented Oct 1, 2024

Version of Hardhat

2.22.12

What happened?

I removed hardhat-gas-reporter as I needed to patch my version of ether v6.13.1 and hardhat-gas-reporter was blocking as it use an obselete version of ether v5.

Now I have the following error when forking:

Error HH801: Plugin @nomicfoundation/hardhat-toolbox requires the following dependencies to be installed: hardhat-gas-reporter.
Please run: npm install --save-dev "hardhat-gas-reporter@^1.0.8"

Looking at https://github.com/cgewecke/hardhat-gas-reporter/blob/v2.2.1/package.json, it seems that hardhat-gas-reporter already support ether 6 since v2, however, hardhat toolbox as a peerDependencies for it using 1.0.8, outdated.

I have tried to install the 2.2.1, but the fork command just hang, I guess it is not compatible.

Minimal reproduction steps

In a mono repo, install ethers v6 and hardhat-toolbox, then run yarn why ethers

Search terms

Relates to cgewecke/hardhat-gas-reporter#246

@fvictorio fvictorio added this to Hardhat Oct 1, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Hardhat Oct 1, 2024
@kopax kopax changed the title Monorepo cannot patch ether du to hardhat-toolbox using obselete version of ethers Monorepo cannot patch ethers du to hardhat-toolbox using obselete version of hardhat-gas-reporter Oct 1, 2024
@ethos-vitalii
Copy link

Seems related to #5555

@ChristopherDedominici
Copy link
Contributor

Closing this issue as the work item is already being tracked here: #5555.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat Nov 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

No branches or pull requests

4 participants
@kopax @ChristopherDedominici @ethos-vitalii and others