Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Not firing renderEnd on lineChart #55

Open
jayflaherty75 opened this issue Oct 6, 2016 · 8 comments
Open

Not firing renderEnd on lineChart #55

jayflaherty75 opened this issue Oct 6, 2016 · 8 comments

Comments

@jayflaherty75
Copy link

Issue encountered on Chrome and Firefox using d3 v3.5.17, nvd3 v1.8.4, and react v15.3.2. Ready and renderStart events fire normally. RenderEnd simply never fires.

@topicus
Copy link
Contributor

topicus commented Oct 11, 2016

@jayflaherty75 NVD3 render_end event is not consistent across charts. I need to find some time to create a PR against nvd3 repository.

@jayflaherty75
Copy link
Author

If you can give me some specifics on what needs to happen in NVD3 to get renderEnd() to fire, I may be able to help.

Thanks,
Jason

@Sharpounet
Copy link

Same here, i would like to know if there is a fix to know when the render is completed.

@topicus
Copy link
Contributor

topicus commented Dec 5, 2016

@Sharpounet @jayflaherty75 Sorry it's been awhile, I've been pulled in another project. I will take a look today and try to provide a solution.

@Sharpounet
Copy link

Thanks a lot @topicus
I will take a look as well

@james-cordeiro
Copy link
Contributor

@topicus - Any progress on this in the last 7 days? I need renderEnd to fire for LinePlusBarChart - otherwise I could take a look and provide PR if you wish..

@james-cordeiro
Copy link
Contributor

@topicus PR created as a merge commit - my fix enables at least linePlusBarChart to fire the renderEnd event.

topicus added a commit that referenced this issue Dec 16, 2016
added linePlusBarChart dispatcher type - renderEnd fix #55
@Sharpounet
Copy link

It's ok for linePlusBarChart but the problem still exists for lineChart.
I'm wondering if the problem is to call the dispatch on "dispatcher = this.chart.lines.dispatch;" and not "dispatcher = this.chart.dispatch;"... I'm a bit lost.

@topicus topicus reopened this Dec 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants