-
-
Notifications
You must be signed in to change notification settings - Fork 316
[ADD][16.0] base_group_erp_user & base_group_erp_user_role #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
fa9a55a to
2a88798
Compare
d38693f to
9cc5bf1
Compare
9cc5bf1 to
8fadaf6
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
|
It looks similar to something I developped, some monthes ago. However, I don't see the possibility to avoid right escalation. Or did I missed something ? https://github.com/grap/grap-odoo-incubator/tree/16.0/user_limited_access_settings |
|
@legalsylvain It looks a bit similar indeed, about rights escalation, we use theses modules with the ones in this PR #349 so there is only a group of users who can edit user rights |
sbejaoui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code review + Functional test
| @api.model | ||
| def _get_erp_user_system_forbidden_fields(self): | ||
| return [ | ||
| "groups_id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to call the super and extends/append the result with your new field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have raised a NotImplementedError in the mixin to be honest so I don't think it's necessary here
| @api.model | ||
| def _get_erp_user_system_forbidden_fields(self): | ||
| return [ | ||
| "implied_ids", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to call the super here too
Theses new modules adds a new first level in "Administration" groups to allow create users, groups and roles without being able to change the groups of a user, the groups of a role, the groups of a role and the roles assigned to users.