Skip to content

Conversation

@benwillig
Copy link
Contributor

Theses new modules adds a new first level in "Administration" groups to allow create users, groups and roles without being able to change the groups of a user, the groups of a role, the groups of a role and the roles assigned to users.

@benwillig benwillig force-pushed the 16.0-add_base_group_erp_user-bwi branch from fa9a55a to 2a88798 Compare April 23, 2025 15:04
@benwillig benwillig force-pushed the 16.0-add_base_group_erp_user-bwi branch 2 times, most recently from d38693f to 9cc5bf1 Compare April 25, 2025 07:55
@benwillig benwillig force-pushed the 16.0-add_base_group_erp_user-bwi branch from 9cc5bf1 to 8fadaf6 Compare April 25, 2025 07:59
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 24, 2025
@legalsylvain
Copy link
Contributor

It looks similar to something I developped, some monthes ago. However, I don't see the possibility to avoid right escalation. Or did I missed something ?

https://github.com/grap/grap-odoo-incubator/tree/16.0/user_limited_access_settings

@benwillig
Copy link
Contributor Author

@legalsylvain It looks a bit similar indeed, about rights escalation, we use theses modules with the ones in this PR #349 so there is only a group of users who can edit user rights

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 31, 2025
Copy link

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review + Functional test

@api.model
def _get_erp_user_system_forbidden_fields(self):
return [
"groups_id",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to call the super and extends/append the result with your new field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have raised a NotImplementedError in the mixin to be honest so I don't think it's necessary here

@api.model
def _get_erp_user_system_forbidden_fields(self):
return [
"implied_ids",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to call the super here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants