Skip to content

Commit 05c6bef

Browse files
committed
[FIX] base_cancel_confirm: split method to update value in docs
1 parent 22762d7 commit 05c6bef

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

base_cancel_confirm/model/base_cancel_confirm.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,11 @@ def open_cancel_confirm_wizard(self):
4949
}
5050
return action
5151

52+
def _get_value_clear_cancel(self):
53+
return {"cancel_confirm": False, "cancel_reason": False}
54+
5255
def clear_cancel_confirm_data(self):
53-
self.write({"cancel_confirm": False, "cancel_reason": False})
56+
self.write(self._get_value_clear_cancel())
5457

5558
def get_view(self, view_id=None, view_type="form", **options):
5659
res = super().get_view(view_id=view_id, view_type=view_type, **options)

base_cancel_confirm/wizard/cancel_confirm.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,21 @@ class CancelConfirm(models.TransientModel):
1818
required=True,
1919
)
2020

21+
def _get_dict_update(self):
22+
"""Hooks this method to update value in docs"""
23+
dict_update = {"cancel_confirm": True}
24+
# Cancel Reason
25+
if self.has_cancel_reason in ["optional", "required"]:
26+
dict_update.update({"cancel_reason": self.cancel_reason})
27+
return dict_update
28+
2129
def confirm_cancel(self):
2230
self.ensure_one()
2331
res_model = self._context.get("cancel_res_model")
2432
res_ids = self._context.get("cancel_res_ids")
2533
cancel_method = self._context.get("cancel_method")
2634
docs = self.env[res_model].browse(res_ids)
27-
docs.write({"cancel_confirm": True})
28-
# Cancel Reason
29-
if self.has_cancel_reason in ["optional", "required"]:
30-
docs.write({"cancel_reason": self.cancel_reason})
35+
dict_update = self._get_dict_update()
36+
docs.write(dict_update)
3137
res = getattr(docs, cancel_method)()
3238
return res

0 commit comments

Comments
 (0)