#382 Fix setting bool field with null

j3nsch · j3nsch · commit fab4232c8e10 · 2025-12-09T16:42:14.000+01:00
diff --git a/library/Opus/Model/Field.php b/library/Opus/Model/Field.php
@@ -328,7 +328,7 @@ public function setValue($value)
                 case 'bool':
                     // Initially the stored value is null which matches false, but field needs to be set
                     // TODO better way?
-                    if ((bool) $value === (bool) $this->value && ! $this->value === null) {
+                    if ((bool) $value === (bool) $this->value && ($this->value !== null || $value === null)) {
                         return $this;
                     }
                     break;

Original file line number	Diff line number	Diff line change
`@@ -328,7 +328,7 @@ public function setValue($value)`
`328`	`328`	`case 'bool':`
`329`	`329`	`// Initially the stored value is null which matches false, but field needs to be set`
`330`	`330`	`// TODO better way?`
`331`		`- if ((bool) $value === (bool) $this->value && ! $this->value === null) {`
	`331`	`+ if ((bool) $value === (bool) $this->value && ($this->value !== null \|\| $value === null)) {`
`332`	`332`	`return $this;`
`333`	`333`	`}`
`334`	`334`	`break;`