You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
add extra category to json file for DCE models #86
Most contributions in DCE models supplied one fitting approach to fit the DCE models. e.g. NLLS or LLSQ.
OGJ_OsloU_Norway has two: NLLS and LLSQ. Both methods have been tested and result in separate csv files. In the json file there is currently no category to classify these different contributions. In the notebooks these are pulled together as we look for unique contributions (i.e. 'author' in the json file).
As a quick work around I've changed the author name for these contributions into OGJ_OsloU_Norway_NLLS and OGJ_OsloU_Norway_LLSQ. This solves the problem temporarily as the results are displayed separately in the plots. However, it is not a very neat way to do this.
Added a fitting_method field to all entries in results-meta.json and reverted author names to their original format (e.g., OGJ_OsloU_Norway_LLSQ → OGJ_OsloU_Norway).
Updated plotting_results_nb.py to generate a contribution_id that combines author name and fitting method when present (e.g., OGJ_OsloU_Norway (LLSQ)).
Patched all model notebooks to load the new metadata field and use the combined label for plotting, enabling multiple fitting methods from the same author to appear as separate contributions.
Activity
Fix OSIPI#86: Add fitting_method to metadata and clean author names
akashgupta2004 commentedon Mar 2, 2026
Changes made:
fitting_methodfield to all entries inresults-meta.jsonand reverted author names to their original format (e.g.,OGJ_OsloU_Norway_LLSQ→OGJ_OsloU_Norway).plotting_results_nb.pyto generate acontribution_idthat combines author name and fitting method when present (e.g.,OGJ_OsloU_Norway (LLSQ)).