Skip to content

add extra category to json file for DCE models #86

Open

Description

@petravanhoudt

Most contributions in DCE models supplied one fitting approach to fit the DCE models. e.g. NLLS or LLSQ.
OGJ_OsloU_Norway has two: NLLS and LLSQ. Both methods have been tested and result in separate csv files. In the json file there is currently no category to classify these different contributions. In the notebooks these are pulled together as we look for unique contributions (i.e. 'author' in the json file).

As a quick work around I've changed the author name for these contributions into OGJ_OsloU_Norway_NLLS and OGJ_OsloU_Norway_LLSQ. This solves the problem temporarily as the results are displayed separately in the plots. However, it is not a very neat way to do this.

Activity

  1. added a commit that references this issue on Mar 2, 2026
    c1783e1
  2. akashgupta2004 commented on Mar 2, 2026

    @akashgupta2004

    Changes made:

    • Added a fitting_method field to all entries in results-meta.json and reverted author names to their original format (e.g., OGJ_OsloU_Norway_LLSQ → OGJ_OsloU_Norway).
    • Updated plotting_results_nb.py to generate a contribution_id that combines author name and fitting method when present (e.g., OGJ_OsloU_Norway (LLSQ)).
    • Patched all model notebooks to load the new metadata field and use the combined label for plotting, enabling multiple fitting methods from the same author to appear as separate contributions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions