Skip to content

social link heading #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashgoyal0110 opened this issue Jan 31, 2025 · 11 comments
Closed

social link heading #676

yashgoyal0110 opened this issue Jan 31, 2025 · 11 comments
Labels

Comments

@yashgoyal0110
Copy link
Contributor

yashgoyal0110 commented Jan 31, 2025

Describe the bug
'Social link' heading should not be there for the chapters with no social links available

To Reproduce
visit: https://nest.owasp.dev/chapters/kallakkurichi or https://nest.owasp.dev/chapters/rmk-college-of-engineering-and-technology

Expected behaviour
No section for social links should be there

Image
@Prakhar29Sharma
Copy link

I would like to work on this

@Raghavg18
Copy link
Contributor

@arkid15r Can i work on it ?

@arkid15r
Copy link
Collaborator

arkid15r commented Feb 1, 2025

Let's revisit this after merging #678

@Raghavg18
Copy link
Contributor

Surely @arkid15r

@Rusheek
Copy link
Contributor

Rusheek commented Feb 5, 2025

Hey @arkid15r,
If this issue is still unresolved, I would like to work on it. Let me know!

@Raghavg18
Copy link
Contributor

Hey @arkid15r now can we work on this issue ?

@jaiakash
Copy link
Contributor

Can i be assigned this issue @arkid15r ?

@Techipeeyon
Copy link

@arkid15r Can you assign this issue to me. I would like to work on it

@arkid15r
Copy link
Collaborator

@Techipeeyon it seems it's no longer relevant. But you could improve the chapter details page by wrapping the chapter URL to TruncatedText.

@arkid15r arkid15r moved this from Backlog to In progress in Project Nest Mar 30, 2025
@Techipeeyon
Copy link

Techipeeyon commented Mar 31, 2025

@arkid15r I made the changes needed. Truncation is applied, but the URL is not displayed in a truncated format since the width is not fixed. We might need to fix a specific width for the URL area. Is that fine?

@arkid15r
Copy link
Collaborator

@arkid15r I made the changes needed. Truncation is applied, but the URL is not displayed in a truncated format since the width is not fixed. We might need to fix a specific width for the URL area. Is that fine?

@Techipeeyon I guess it is, I'm not sure about the details as I haven't looked into this.

@arkid15r arkid15r moved this from In progress to Todo in Project Nest Apr 16, 2025
@arkid15r arkid15r closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Project Nest Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
7 participants